Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a note on executable google-java-format#414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
suztomo wants to merge1 commit intogoogle:master
base:master
Choose a base branch
Loading
fromsuztomo:note_on_executable

Conversation

suztomo
Copy link
Member

Google-java-format-diff expects an executablegoogle-java-format (link), but this repository does not contain such file. This PR explains how to create such executable in README.md.

@suztomosuztomo changed the titleAdd a note on executablegoogle-java-format.Add a note on executable google-java-formatNov 5, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment@googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️Googlers:Go here for more info.

@suztomo
Copy link
MemberAuthor

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️Googlers:Go here for more info.

@googlebotgooglebot added cla: yes and removed cla: no labelsNov 5, 2019
@cushon
Copy link
Collaborator

Google-java-format-diff expects an executable google-java-format (link), but this repository does not contain such file

I think this was addressed in#44.

@suztomo
Copy link
MemberAuthor

The issue 44 was addressed by adding flag to specify the location of the executable. Still this repository is missing how to create the executable.

@cushon
Copy link
Collaborator

there's alsofa113c6

@suztomo
Copy link
MemberAuthor

That command line option lets users specify a custom JAR file, without using an executable. This does not describe how to create the executable.

@cushon
Copy link
Collaborator

aren't the two approaches equivalent?

@suztomo
Copy link
MemberAuthor

Yes the effect of two approaches (the custom JAR approach and the executable-in-PATH approach) is the same. This equivalence should not block enhancing the document for one approach. By the way, I like the executable-in-PATH approach because the command line parameter is shorter for google-java-format-diff.py.

@suztomo
Copy link
MemberAuthor

@eaftan Thank you for checking. Would you merge this PR? I don’t have write access.

@eaftan
Copy link
Contributor

@suztomo I'm testing a new sync workflow. By approving this PR, I had hoped it would be automatically pulled into an internal CL, which we could then approve and submit internally. Then that change would be synced outward and this PR closed. But approving this didn't create the internal CL. Let me poke it and see if I can make it work.

@eaftaneaftan closed thisMay 1, 2020
@eaftaneaftan reopened thisMay 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer

@eaftaneaftaneaftan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@suztomo@googlebot@cushon@eaftan

[8]ページ先頭

©2009-2025 Movatter.jp