Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fixRemoveUnusedImportsStep leftovers#1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Pankraz76 wants to merge1 commit intogoogle:master
base:master
Choose a base branch
Loading
fromPankraz76:fix-fix-blindspot-on-`RemoveUnusedImportsStep`

Conversation

Pankraz76
Copy link

@Pankraz76Pankraz76 commentedJun 26, 2025•
edited
Loading

fix#1261

@iddeepak kindly request your eyes on this.

  • execute and debug some test locally on IDE?
  • maybe work this out?
    • tc exposed some issues
[ERROR] Failures: [ERROR]   RemoveUnusedImportsTest.removeUnused:485 value of:    removeUnusedImports(...)expected:    interface Test { private static void foo() {} }        but was:    import java.lang.Foo;    interface Test { private static void foo() {} }        [ERROR]   RemoveUnusedImportsTest.removeUnused:485 value of:    removeUnusedImports(...)expected:    …pkg.Constants.FOO;        public class Test …but was:    …pkg.Constants.FOO;            public class Test …[ERROR]   RemoveUnusedImportsTest.removeUnused:485 value of:    removeUnusedImports(...)diff (-expected +actual):    @@ -1,3 +1,4 @@    +import static java.util.Collections.*;     import static java.util.Collections.emptyList;          class Test {[ERROR]   RemoveUnusedImportsTest.removeUnused:485 value of:    removeUnusedImports(...)expected:    class Test {      java.…but was:        class Test {      java.…[ERROR]   RemoveUnusedImportsTest.removeUnused:485 value of:    removeUnusedImports(...)diff (-expected +actual):    @@ -1,3 +1,4 @@    +import static java.lang.Math.*;     import static java.lang.Math.PI;          class Test {[ERROR]   RemoveUnusedImportsTest.removeUnused:485 value of:    removeUnusedImports(...)expected:    // This is a comment mentioning ArrayList    class Test {}        but was:        // This is a comment mentioning ArrayList    class Test {}        [ERROR]   RemoveUnusedImportsTest.removeUnused:485 value of:    removeUnusedImports(...)diff (-expected +actual):    @@ -1,5 +1,6 @@     package com.foo;     import static com.foo.Outer.A;    +import com.foo.*;     import com.foo.B;     import com.bar.C;     class Test {[INFO] [ERROR] Tests run: 1580, Failures: 7, Errors: 0, Skipped: 0

@google-claGoogle CLA
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Author

@Pankraz76Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

WIP

@Pankraz76Pankraz76force-pushed thefix-fix-blindspot-on-`RemoveUnusedImportsStep` branch 3 times, most recently from33f45fd to91080e2CompareJune 26, 2025 12:42
@Pankraz76Pankraz76 marked this pull request as ready for reviewJune 26, 2025 12:42
@Pankraz76Pankraz76force-pushed thefix-fix-blindspot-on-`RemoveUnusedImportsStep` branch from91080e2 to05caad3CompareJune 26, 2025 12:43
@iddeepakiddeepak mentioned this pull requestJun 28, 2025
@iddeepak
Copy link

@Pankraz76
I have pushed a few small tweaks—feel free to pull them into your branch and let me know what you think or if anything needs further adjustment PR#1266
Thank you!

Pankraz76 reacted with thumbs up emoji

@Pankraz76Pankraz76 changed the titleblindspot onRemoveUnusedImportsStepfixRemoveUnusedImportsStep leftoversJun 28, 2025
@Pankraz76Pankraz76force-pushed thefix-fix-blindspot-on-`RemoveUnusedImportsStep` branch from05caad3 tocf8220eCompareJune 28, 2025 12:50
import org.junit.runners.JUnit4;

import java.util.List;

Copy link
Author

@Pankraz76Pankraz76Jun 28, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this seems to be an issue now imposed by the new fixes done by me.

@Pankraz76Pankraz76force-pushed thefix-fix-blindspot-on-`RemoveUnusedImportsStep` branch fromcf8220e to8e6d995CompareJune 28, 2025 13:26
"import $1" +sep +sep);

// Remove multiple blank lines elsewhere in imports section
s =s.replaceAll("(?m)^import .+" +sep +"\\s+" +sep +"(?=import)","import $1" +sep);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

items:

so the formatter test failing on the previous version is fixed now, but still failing other tests as well.

At least only related to the class, except of the IndexOutOfBounds.

[ERROR] Failures: [ERROR]   RemoveUnusedImportsTest.removeUnused:577 value of:    removeUnusedImports(...)diff (-expected +actual):    @@ -1,5 +1,4 @@     package p;    -import java.lang.Foo;     import java.lang.Foo.Bar;     import p.Baz;     import p.Baz.Bork;[ERROR]   RemoveUnusedImportsTest.removeUnused:577 value of:    removeUnusedImports(...)expected:    …pkg.Constants.FOO;        public class Test …but was:    …pkg.Constants.FOO;            public class Test …[ERROR]   RemoveUnusedImportsTest.removeUnused:577 value of:    removeUnusedImports(...)expected:    class Test {      java.…but was:        class Test {      java.…[ERROR] Errors: [ERROR]   MainTest.optimizeImportsDoesNotLeaveEmptyLines:246 » IndexOutOfBounds No group...[INFO] [ERROR] Tests run: 1580, Failures: 3, Errors: 1, Skipped: 0

@Pankraz76
Copy link
Author

@Pankraz76Pankraz76force-pushed thefix-fix-blindspot-on-`RemoveUnusedImportsStep` branch from87ae466 toe6c2323CompareAugust 6, 2025 10:18
@Pankraz76
Copy link
Author

can not fix remaining tests, ether disable or fix.

Kindly request some feedback. Thanks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer

@iddeepakiddeepakiddeepak left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blindspot onRemoveUnusedImportsStep
2 participants
@Pankraz76@iddeepak
[8]ページ先頭
©2009-2025 Movatter.jp