- Notifications
You must be signed in to change notification settings - Fork898
fix-#1201/refactor-design-smells#1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bishaddebroy wants to merge1 commit intogoogle:masterChoose a base branch frombishaddebroy:fix-#1201/refactor-design-smells
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
fix-#1201/refactor-design-smells#1202
bishaddebroy wants to merge1 commit intogoogle:masterfrombishaddebroy:fix-#1201/refactor-design-smells
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Refactor JavacTokens to Address Design Smells
Description
This PR implements three refactorings in JavacTokens.java to address several identified design smells. The changes improve code organization and maintainability while maintaining all existing functionality.
Changes Made
1. Extract Class - TokenPosition
2. Move Method - Position Validation
3. Move Field - Position Fields
Testing
Implementation Notes
Related Issues
Resolves#1201 - Design smells in JavacTokens class
Documentation
Change Impact
Checklist
Additional Notes
These refactorings improve code quality while carefully preserving all existing behavior. The changes make the codebase more maintainable and reduce the likelihood of position-related errors.
/cc@reviewer1@reviewer2