Commit75dcd53

authored and

Error Prone Team

committed

Fix the Optional wrapping in the description of NonCanonicalStaticMemberImport.

PiperOrigin-RevId: 835159948

1 parent10f5424 commit75dcd53Copy full SHA for 75dcd53

File tree

-1

lines changed

core/src
- main/java/com/google/errorprone/bugpatterns
  - NonCanonicalStaticMemberImport.java
- test/java/com/google/errorprone/bugpatterns
  - NonCanonicalStaticMemberImportTest.java

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public Description matchImport(ImportTree tree, VisitorState state) {`
`48`	`48`	`.setMessage(`
`49`	`49`	`String.format(`
`50`	`50`	`"Static import of '%s' uses non-canonical name; prefer '%s'",`
`51`		`-importInfo.simpleName(),importInfo.canonicalName()))`
	`51`	`+importInfo.simpleName().get(),importInfo.canonicalName()))`
`52`	`52`	`.build();`
`53`	`53`	`}`
`54`	`54`	`}`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,10 @@ public class A {`
`39`	`39`	`public static final int foo() {`
`40`	`40`	`return 42;`
`41`	`41`	`}`
	`42`	`+`
	`43`	`+ public static final int bar() {`
	`44`	`+ return 42;`
	`45`	`+ }`
`42`	`46`	`}`
`43`	`47`	`""")`
`44`	`48`	`.addSourceLines(`
`@@ -57,6 +61,8 @@ public class B extends A {}`
`57`	`61`
`58`	`62`	`// BUG: Diagnostic contains: import static a.A.foo;`
`59`	`63`	`import static b.B.foo;`
	`64`	`+ // BUG: Diagnostic contains: of 'bar'`
	`65`	`+ import static b.B.bar;`
`60`	`66`
`61`	`67`	`class Test {}`
`62`	`68`	`""")`

Comments

(0)