- Notifications
You must be signed in to change notification settings - Fork511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Compatibility with proxy.golang.org#1974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@sanyatuning Thanks for your contribution to Athens! Do you mind writing a test that ensures this behaivor? |
matt0x6F approved these changesAug 2, 2024
DrPsychick referenced this pull request in gomods/athens-chartsSep 14, 2024
This PR contains the following updates:| Package | Update | Change ||---|---|---|| [gomods/athens](https://redirect.github.com/gomods/athens) | minor |`v0.14.1` -> `v0.15.1` |---### Release Notes<details><summary>gomods/athens (gomods/athens)</summary>###[`v0.15.1`](https://redirect.github.com/gomods/athens/releases/tag/v0.15.1)[CompareSource](https://redirect.github.com/gomods/athens/compare/v0.15.0...v0.15.1)#### What's Changed- update-github-action(deps): bump goreleaser/goreleaser-action from 5to 6 by [@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/gomods/athens/pull/1969](https://redirect.github.com/gomods/athens/pull/1969)- update-github-action(deps): bump docker/build-push-action from 5 to 6by [@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/gomods/athens/pull/1971](https://redirect.github.com/gomods/athens/pull/1971)- Add aad auth option when using azure storage account by[@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)- Fix helm install command in docs by[@​sb464f](https://redirect.github.com/sb464f) in[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)- Switch from ADAL to AzIdentity, Add Azure Storage Token Refresh, andUpdate Golang Version by[@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in[https://github.com/gomods/athens/pull/1977](https://redirect.github.com/gomods/athens/pull/1977)- Compatibility with proxy.golang.org for list not found responses by[@​sanyatuning](https://redirect.github.com/sanyatuning) in[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)- Fix: Change goreleaser flag from --rm-dist to --clean by[@​matt0x6F](https://redirect.github.com/matt0x6F) in[https://github.com/gomods/athens/pull/1984](https://redirect.github.com/gomods/athens/pull/1984)#### New Contributors- [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker)made their first contribution in[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)- [@​sb464f](https://redirect.github.com/sb464f) made their firstcontribution in[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)- [@​sanyatuning](https://redirect.github.com/sanyatuning) madetheir first contribution in[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)**Full Changelog**:gomods/athens@v0.14.1...v0.15.1###[`v0.15.0`](https://redirect.github.com/gomods/athens/releases/tag/v0.15.0)[CompareSource](https://redirect.github.com/gomods/athens/compare/v0.14.1...v0.15.0)#### What's Changed- update-github-action(deps): bump goreleaser/goreleaser-action from 5to 6 by [@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/gomods/athens/pull/1969](https://redirect.github.com/gomods/athens/pull/1969)- update-github-action(deps): bump docker/build-push-action from 5 to 6by [@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/gomods/athens/pull/1971](https://redirect.github.com/gomods/athens/pull/1971)- Add aad auth option when using azure storage account by[@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)- Fix helm install command in docs by[@​sb464f](https://redirect.github.com/sb464f) in[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)- Switch from ADAL to AzIdentity, Add Azure Storage Token Refresh, andUpdate Golang Version by[@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in[https://github.com/gomods/athens/pull/1977](https://redirect.github.com/gomods/athens/pull/1977)- Compatibility with proxy.golang.org for list not found responses by[@​sanyatuning](https://redirect.github.com/sanyatuning) in[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)#### New Contributors- [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker)made their first contribution in[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)- [@​sb464f](https://redirect.github.com/sb464f) made their firstcontribution in[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)- [@​sanyatuning](https://redirect.github.com/sanyatuning) madetheir first contribution in[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)**Full Changelog**:gomods/athens@v0.14.1...v0.15.0</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/gomods/athens-charts).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->---------Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Co-authored-by: DrPsychick <drpsychick@drsick.net>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Empty response body when major version not found.
The official proxy responds with a non-empty body.
(And some library depends on this)
How is the fix applied?
I created a simplified solution for my case.
Can you update it to fit your conventions?
What GitHub issue(s) does this PR fix or close?
Fixesicholy/gomajor#34