Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
build(deps): bump github.com/go-critic/go-critic from 0.13.0 to 0.14.0#6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ldez merged 1 commit intomainfromdependabot/go_modules/github.com/go-critic/go-critic-0.14.0Oct 15, 2025
Merged
build(deps): bump github.com/go-critic/go-critic from 0.13.0 to 0.14.0#6135
ldez merged 1 commit intomainfromdependabot/go_modules/github.com/go-critic/go-critic-0.14.0Oct 15, 2025
+3 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
66c00e2 toe844622CompareBumps [github.com/go-critic/go-critic](https://github.com/go-critic/go-critic) from 0.13.0 to 0.14.0.- [Release notes](https://github.com/go-critic/go-critic/releases)- [Commits](go-critic/go-critic@v0.13.0...v0.14.0)---updated-dependencies:- dependency-name: github.com/go-critic/go-critic dependency-version: 0.14.0 dependency-type: direct:production update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>
e844622 to38fc914Compareldez approved these changesOct 15, 2025
f61b811 intomain 18 of 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ptman commentedOct 30, 2025 • edited by ldez
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ldez
Uh oh!
There was an error while loading.Please reload this page.
Did you test gocritic? Started failing: |
Member
bombsimon commentedOct 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, all linters are tested in our pipeline. This doesn't seem to affect all codebases, working fine on › golangci-lint versiongolangci-lint has version 2.6.0 built with go1.25.3 from fb09c371 on 2025-10-29T19:41:04Z› golangci-lint run --default none --enable gocritic0 issues. If possible I think it would be good to add a repro togo-critic/go-critic#1514 |
@ptman can you open a dedicated issue (with a reproducible example)? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
dependenciesRelates to an upstream dependency goPull requests that update Go code linter: update versionUpdate version of linter
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Bumpsgithub.com/go-critic/go-critic from 0.13.0 to 0.14.0.
Release notes
Sourced fromgithub.com/go-critic/go-critic's releases.
Commits
26869a4deps: bump golang.org/x/tools from 0.35.0 to 0.36.0 (#1500)5beeab6ci: bump actions/setup-go from 5 to 6 (#1503)188b8b0ci: bump actions/checkout from 4 to 5 (#1501)24d5174deps: bump golang.org/x/tools from 0.34.0 to 0.35.0 (#1498)db2ec6fdeps: bump golang.org/x/tools from 0.33.0 to 0.34.0 (#1492)dfe69b7docs/readme: add Homebrew install instructions (#1491)cf715f9auto generate doc [bot]cafe067checker: addzeroByteRepeatfor avoidingbytes.Repeat([]byte{0}, x)(#1488)58947dfdeps: bump golang.org/x/tools from 0.32.0 to 0.33.0 (#1489)ac47943checker/badCond: rhs should be also check for safe expr (#1486)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)