Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
docs: gocritic enabled-checks and disabled-checks can be combined#6090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedSep 19, 2025
|
Hey, thank you for opening your first Pull Request ! |
The documentation currently indicates that enable-checks anddisabled-checks can't be combined for gocritic. That is however notaccurate: as per InferEnabledChecks in the gocritic wrapper,* if enable-all is set, all available checks are added to the set of enabled checks* otherwise, unless disable-all is set, the default checks are added to the set of enabled checks* then the checks corresponding to each enabled tag are added* then all enabled checks are added (with a warning if a check is enabled multiple times)* then the checks corresponding to each disabled tag are removed* finally, all disabled checks are removed (with a warning if a check wasn't enabled)Using both enabled-checks and disabled-checks is useful when keepingthe default set of checks as reference.This adjusts the documentation to match the implementation.Signed-off-by: Stephen Kitt <skitt@redhat.com>
28dd63d to0d6e043CompareHello@skitt, could you sign the CLA? |
Sorry, I missed that part of the contribution workflow — I’ll have to get approval from our legal department. |
Uh oh!
There was an error while loading.Please reload this page.
The documentation currently indicates that enable-checks and disabled-checks can't be combined for gocritic. That is however not accurate: as per InferEnabledChecks in the gocritic wrapper,
Using both enabled-checks and disabled-checks is useful when keeping the default set of checks as reference.
This adjusts the documentation to match the implementation.
related to#4458