Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

godox: trim filepath from report messages#5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ldez merged 1 commit intogolangci:mainfromldez:feat/godox-trim-message
Aug 9, 2025

Conversation

@ldez
Copy link
Member

@ldezldez commentedAug 6, 2025

Fixes#5976

stanhu reacted with heart emoji
@ldezldez added this to thev2-unreleased milestoneAug 6, 2025
@ldezldez added enhancementNew feature or improvement linter: updateUpdate the linter implementation inside golangci-lint labelsAug 6, 2025
@bombsimon
Copy link
Member

Shouldn't this be fixed upstream? Or is it abandoned?

@ldezldez requested a review frombombsimonAugust 9, 2025 21:49
@ldez
Copy link
MemberAuthor

ldez commentedAug 9, 2025

It will not be fixed upstream because this is a part of the expected output of this linter.

@bombsimon
Copy link
Member

I guess I mean why do the linter expect relative/short path on Linux but full path on macOS. That's just inconsistency to me.

But yes I agree the linter expects to show which file and line is affected and no matter the format it will be duplicated info in golangci-lint which isn't needed so 🤷

@ldezldez merged commitef6ead8 intogolangci:mainAug 9, 2025
18 checks passed
@ldezldez deleted the feat/godox-trim-message branchAugust 9, 2025 22:08
@ldezldez modified the milestones:v2-unreleased,v2.4Aug 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bombsimonbombsimonbombsimon approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or improvementlinter: updateUpdate the linter implementation inside golangci-lint

Projects

None yet

Milestone

v2.4

Development

Successfully merging this pull request may close these issues.

godox: report print absolute path

2 participants

@ldez@bombsimon

[8]ページ先頭

©2009-2025 Movatter.jp