Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

go1.25 support#5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ldez merged 15 commits intomainfromfeat/go1.25
Aug 13, 2025
Merged

go1.25 support#5872

ldez merged 15 commits intomainfromfeat/go1.25
Aug 13, 2025

Conversation

@ldez
Copy link
Member

@ldezldez commentedJun 11, 2025
edited
Loading

This PR is to evaluate and prepare golangci-lint togo1.25

This PR will evolve during the beta and RC phases ofgo1.25.
The PR is a draft and will be rebased and modified several times during the RC phase.

https://go.dev/wiki/Go-Release-Cycle

Questions and problems related to go1.25 should be reported in the issue#5873.

Todo:

  • Update workflows
  • Update base Docker images
  • Update minimum Go version insidego.mod
  • Update gci standard packages list
  • Use new language features from go1.n-1
  • Update testdata tests

golangci-lint is a free and open-source project built by volunteers.

If you value it, please consider donating or asking your company to do so, we appreciate it! ❤️

  • Donate ❤️: 2€ /_$2 / 2£ / 350円 / 15元 / 100₴ / 200₽ / 1500원 / 12 B$ per month is important
  • Ask your company to donate (if needed, we can exchange by email: info at golangci dot com)

OSS are free to use but not free of work.

atc0005, woswos, and bombsimon reacted with hooray emoji
@ldezldez added the enhancementNew feature or improvement labelJun 11, 2025
@ldezldez mentioned this pull requestJun 11, 2025
@ldezldezforce-pushed thefeat/go1.25 branch 2 times, most recently from0a66fbb to63806ddCompareJune 21, 2025 10:16
fastcat added a commit to fastcat/gdev that referenced this pull requestJul 11, 2025
@ldezldezforce-pushed thefeat/go1.25 branch 2 times, most recently from44a3470 to7a2969fCompareAugust 12, 2025 09:14
@johnsonjh
Copy link

@ldez Go 1.25.0 has been released

ldez reacted with eyes emoji

@ldez
Copy link
MemberAuthor

ldez commentedAug 12, 2025
edited
Loading

I'm waiting for the official announcement.

Thetag has been created there are 20 minutes.

johnsonjh reacted with thumbs up emoji

@johnsonjh
Copy link

Website is updated -https://go.dev/doc/go1.25

… haven’t gotten email though

@ldez
Copy link
MemberAuthor

The GitHub Action environment is not ready yet.

@ldezldez marked this pull request as ready for reviewAugust 12, 2025 21:30
@ldez
Copy link
MemberAuthor

ldez commentedAug 12, 2025
edited
Loading

The Docker images are not available yet:

And based on what I can seehere, the images will not be available quickly.
I think this is related to an update of the base Alpine image used by official Docker images, and also an update to Debian Trixie.

@ldez
Copy link
MemberAuthor

ldez commentedAug 12, 2025
edited
Loading

🤔 either I use the Docker image of go1.25rc3 or I have to wait for the update of the official Docker image.

FYI, the Go Docker image is used to build golangci-lint Docker image, but doesn't impact the build of our binaries.

@ldez
Copy link
MemberAuthor

ldez commentedAug 12, 2025
edited
Loading

Based on my experience with the official Docker images, I think the current build stack within the Docker CI (due to the Alpine and Trixie update) will require a significant amount of time.

I will wait a bit and re-evaluate the situation in a few hours.

Note: currently it's midnight in my TZ.

johnsonjh and yxxhero reacted with thumbs up emoji

@ldez
Copy link
MemberAuthor

ldez commentedAug 13, 2025
edited
Loading

The PR to create the official Go Docker image is open, but the Docker CI still has many elements in the queue.

So I will postpone the release of golangci-lint for now.

Note: currently it's 2 am in my TZ.

BlackHole1 and woswos reacted with heart emoji

@ldez
Copy link
MemberAuthor

TheDocker CI is still busy because of the update to Trixie.

And thePR about Go has not been merged yet.
I think they will merge the PR in a few hours (they are in the US time zone), but as the CI queue is full, it is difficult to say how much time it will take to have the Go Docker image.

@johnsonjh
Copy link

johnsonjh commentedAug 13, 2025
edited
Loading

@ldez Looks likedocker-library/official-images#19675 is closed now anddocker-library/golang#568 is resolved. Still not yet pushed onto DockerHub though.

@ldez
Copy link
MemberAuthor

ldez commentedAug 13, 2025
edited
Loading

Please, I already follow the topic, I don't need extra notifications.

The merge of the Go PR is just the first step; now, the images must be built.

johnsonjh reacted with heart emoji

@ldez
Copy link
MemberAuthor

ldez commentedAug 13, 2025
edited
Loading

I'm used to this kind of situation with official images, so for me it's clear, but maybe it's not for everyone

The situation is exceptional (but it's a recurring topic) due to the release of a base element of multiple images (in this case, Debian Trixie).

The Docker team must build or rebuild most of the official Docker images (note: official Docker images process != DockerHub images process).

This produces a huge number of jobs in their CI.
The CI queue is full, and so the images will take several hours before being ready.

The DockerHub displays some versions, but they are not available: the updates of the image homepage are not correlated to the availability of the images.

To check the availability (all the architectures must appear and no errors):

$docker manifest inspect golang:1.25-alpineno such manifest: docker.io/library/golang:1.25-alpine$docker manifest inspect golang:1.25no such manifest: docker.io/library/golang:1.25

You can also check the tags (all the architectures must appear):https://hub.docker.com/_/golang/tags

@Gobd
Copy link

Just curious, but what is the issue with updating the Go version in thego.mod file (maybe it has to be thetoolchain line?) which will control what version is used to build as far as I know. You can use any recent Docker image but specify Go 1.25 in the go.mod and that is what will be used to build. I suspect there must be some issue with that but maybe not.

@ldez
Copy link
MemberAuthor

#5872 (comment)

@erka
Copy link

It looks like the images are available

johnsonjh reacted with hooray emoji

@ldezldez added this to thev2-unreleased milestoneAug 13, 2025
@ldezldez merged commitfca8610 intomainAug 13, 2025
18 checks passed
@ldezldez deleted the feat/go1.25 branchAugust 13, 2025 20:36
@ldez
Copy link
MemberAuthor

I just took a few minutes to eat, and the images were available during this time.

bombsimon reacted with hooray emojibombsimon reacted with heart emoji

@ldez
Copy link
MemberAuthor

ldez commentedAug 13, 2025
edited
Loading

The Docker images are still not available...

ERROR: failed to build: failed to solve: failed to resolve source metadata for docker.io/library/golang:1.25: no match for platform in manifest: not found

https://github.com/golangci/golangci-lint/actions/runs/16948897429/job/48036752940#step:10:183

I will re-launch the job later, when all the images from all architectures will be really available.

Note: currently it's closed to midnight in my TZ but I will stay up until the availability of the images and the release is done.

@golangcigolangci locked and limited conversation to collaboratorsAug 13, 2025
@ldezldez modified the milestones:v2-unreleased,v2.4Aug 14, 2025
@ldez
Copy link
MemberAuthor

It's 2 am: Golangci-lint v2.4.0 is available with go1.25 support.

I want to remind you that my only income is from donations:

The PR discussion is locked to centralize feedback on the issue.

Questions and problems related to go1.25 should be reported in the issue#5873.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@alexandearalexandearalexandear approved these changes

+1 more reviewer

@nightlyonenightlyonenightlyone left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or improvement

Projects

None yet

Milestone

v2.4

Development

Successfully merging this pull request may close these issues.

7 participants

@ldez@johnsonjh@Gobd@erka@nightlyone@alexandear

[8]ページ先頭

©2009-2025 Movatter.jp