Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
Prebuilt binaries supporting plugins / custom linters#3361
-
There has been some previous discussion about this in some other issues:
Since some of those weren't totally relevant to the attached issues and/or closed, I thought it might make sense to start a new discussion about ways that it might be possible to use prebuilt As I understand it, there are a few requirements needed to support Go plugins (copy-pasting from#3259 (reply in thread) for reference):
I believe (although not 100% positive) that for the first three of these, the Go runtime verifies these and refuses to load a plugin if these conditions are not met. I am also under the impression that
With that in mind, does it seem like a reasonable option to publish two versions of the binaries, one with plugin support ( Barring any functional changes like publishing plugin-compatible binaries, I think there might be two things that would help users understand what's going on with the status quo:
|
BetaWas this translation helpful?Give feedback.
All reactions
Hello,
it's not possible to pre-build something compatible with plugins because the plugin and the binary must be built with the same Go stack/environment.CGO_ENABLED is only one of the requirements.
Replies: 1 comment 3 replies
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
Hello, |
BetaWas this translation helpful?Give feedback.
All reactions
-
Should we endeavour to update the docs and improve the error when this is the case so its clear to the user? |
BetaWas this translation helpful?Give feedback.
All reactions
👍 2
-
That means it should still be possible to write a plugin against a specific It seems to me the advantage of having plugin support at all is somewhat diminished if you have to build the binary from scratch anyway — at that point, why not just add your custom lint directly into the binary instead? |
BetaWas this translation helpful?Give feedback.
All reactions
-
FYI, this is now added to the documentation#3468. |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1