Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

go/analysis/passes/shadow: separate package-level variables logic#586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bkreitch wants to merge3 commits intogolang:master
base:master
Choose a base branch
Loading
frombkreitch:shadow-package-variables

Conversation

@bkreitch
Copy link

@bkreitchbkreitch commentedAug 8, 2025•
edited
Loading

Span-based shadow detection across multiple files may produce inconsistent
results due to changes in filename ordering and map iteration. Since only
package-level variables can be shadowed cross-file, this PR handles them
separately using usage-based detection.

Fixesgolang/go#40758
Continues from#583

@gopherbot
Copy link
Contributor

This PR (HEAD:498fb53) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/694037.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 2:

(9 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@bkreitchbkreitchforce-pushed theshadow-package-variables branch from498fb53 tod7e5d6eCompareAugust 8, 2025 19:30
@gopherbot
Copy link
Contributor

This PR (HEAD:d7e5d6e) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/694037.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 3:

(10 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 3:

(5 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@bkreitchbkreitchforce-pushed theshadow-package-variables branch fromd7e5d6e tofe25404CompareAugust 15, 2025 13:05
@gopherbot
Copy link
Contributor

This PR (HEAD:fe25404) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/694037.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 4:

(6 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/694037.
After addressing review feedback, remember topublish your drafts!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x/tools/go/analysis/passes/shadow/cmd/shadow: Failure/success of the linter depends also on filename, not just the content

2 participants

@bkreitch@gopherbot
[8]ページ先頭
©2009-2025 Movatter.jp