- Notifications
You must be signed in to change notification settings - Fork2.3k
go/analysis/passes/shadow: include filename in cross-file shadow error messages#583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
gopherbot commentedAug 1, 2025
This PR (HEAD:a84e523) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396. Important tips:
|
gopherbot commentedAug 1, 2025
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Boris Kreitchman: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Alan Donovan: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
This PR (HEAD:590dc2a) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396. Important tips:
|
gopherbot commentedAug 1, 2025
Message from Alan Donovan: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
This PR (HEAD:102a31b) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396. Important tips:
|
gopherbot commentedAug 1, 2025
Message from Boris Kreitchman: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Boris Kreitchman: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Alan Donovan: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Boris Kreitchman: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
This PR (HEAD:6550bcc) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396. Important tips:
|
gopherbot commentedAug 1, 2025
Message from Alan Donovan: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Boris Kreitchman: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Boris Kreitchman: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Alan Donovan: Patch Set 5: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from t hepudds: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 1, 2025
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-08-01T23:31:18Z","revision":"f296c20964323eb8d873f24b84384bf4410f4ca7"} Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from t hepudds: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from Go LUCI: Patch Set 5: This CL has failed the run. Reason: Tryjobgolang/try/x_tools-go1.23-windows-amd64 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
This PR (HEAD:28b865a) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396. Important tips:
|
gopherbot commentedAug 2, 2025
Message from t hepudds: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-08-02T10:58:23Z","revision":"f06f14a6877937080da87021e7ad8b51ba5563e8"} Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from t hepudds: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 2, 2025
Message from Boris Kreitchman: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 4, 2025
Message from Robert Findley: Patch Set 6: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
gopherbot commentedAug 8, 2025
Message from Alan Donovan: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396. |
Uh oh!
There was an error while loading.Please reload this page.
Improve shadow analyzer error messages to include the filename when
the shadowed declaration is in a different file.
Fixesgolang/go#74843