Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

go/analysis/passes/shadow: include filename in cross-file shadow error messages#583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bkreitch wants to merge2 commits intogolang:master
base:master
Choose a base branch
Loading
frombkreitch:shadow-cross-file

Conversation

@bkreitch
Copy link

@bkreitchbkreitch commentedAug 1, 2025
edited
Loading

Improve shadow analyzer error messages to include the filename when
the shadowed declaration is in a different file.

Fixesgolang/go#74843

ccoVeille reacted with eyes emoji
@bkreitchbkreitch marked this pull request as ready for reviewAugust 1, 2025 16:38
@gopherbot
Copy link
Contributor

This PR (HEAD:a84e523) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD:590dc2a) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD:102a31b) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 4:

(2 comments)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD:6550bcc) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 5: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 5: Commit-Queue+1


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-08-01T23:31:18Z","revision":"f296c20964323eb8d873f24b84384bf4410f4ca7"}


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 5: -Commit-Queue


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjobgolang/try/x_tools-go1.23-windows-amd64 has failed with summary (view all results):


To reproduce, trygomote repro 8707695905016383569.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD:28b865a) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/tools/+/692396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 6: Commit-Queue+1


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-08-02T10:58:23Z","revision":"f06f14a6877937080da87021e7ad8b51ba5563e8"}


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 6: -Commit-Queue


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

This CL has passed the run


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Boris Kreitchman:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 6: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/692396.
After addressing review feedback, remember topublish your drafts!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x/tools/go/analysis/passes/shadow: error message should include filename when shadowed declaration is in another file

2 participants

@bkreitch@gopherbot

[8]ページ先頭

©2009-2025 Movatter.jp