Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:golang/tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base:master
Choose a base ref
Loading
...
head repository:golang/tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare:release-branch.0.24
Choose a head ref
Loading
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3commits
  • 29files changed
  • 1contributor

Commits on Aug 19, 2025

  1. [release-branch.0.24] all: update codereview.cfg for release-branch.0.24

    Forgolang/go#74462Change-Id: Id8789ef59a24b774510c1954f3e757d82c47ab8dReviewed-on:https://go-review.googlesource.com/c/tools/+/697335Reviewed-by: Peter Weinberger <pjw@google.com>TryBot-Bypass: Robert Findley <rfindley@google.com>
    @findleyr@dmitshur
    findleyr authored anddmitshur committedAug 19, 2025
    Configuration menu
    Copy the full SHA
    073a21bView commit details
    Browse the repository at this point in the history

  2. [release-branch.0.24] internal/tokeninternal: move unsafe gopls code …

    …into goplsIn x/tools@v0.24.0, the tokeninternal package accessed the token.FileSetunsafely, and used a trick to force the build to break if ever the sizeof token.FileSet changed. This workaround was only necessary for gopls,but was unfortunately implemented in a package that was reachablethrough the public API of x/tools.In go1.25, the size of the token.FileSet changed, breaking tools thatindirectly depended on this poisoned package. Fix this by moving thegopls logic into gopls: the gopls build will still be broken, but thatdoesn't matter as we only support the most recent version of gopls,which is fixed.Forgolang/go#74462Change-Id: Ied3f7a615cab66d88ec6f4cfe8738f8429865993Reviewed-on:https://go-review.googlesource.com/c/tools/+/697336Reviewed-by: Peter Weinberger <pjw@google.com>TryBot-Bypass: Robert Findley <rfindley@google.com>
    @findleyr@dmitshur
    findleyr authored anddmitshur committedAug 19, 2025
    Configuration menu
    Copy the full SHA
    7b8729bView commit details
    Browse the repository at this point in the history

  3. [release-branch.0.24] gopls: fix the build with go1.25

    Turn the compile-time error in AddExistingFiles into a runtime panic,and avoid it by delegating to the FileSet.AddExistingFiles method ongo1.25.Also disable broken tests. Most of the breakage is related togo/packages or the importer, as there was an export data change that isnot ported to this branch.forgolang/go#74462Change-Id: I430209b329ab88da676253e2bf5f66d1792078bdReviewed-on:https://go-review.googlesource.com/c/tools/+/697337LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Peter Weinberger <pjw@google.com>
    @findleyr@dmitshur
    findleyr authored anddmitshur committedAug 19, 2025
    Configuration menu
    Copy the full SHA
    faecc48View commit details
    Browse the repository at this point in the history
Loading
[8]ページ先頭
©2009-2025 Movatter.jp