- Notifications
You must be signed in to change notification settings - Fork2.3k
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:golang/tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:30def9c
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:golang/tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:789ea55
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 3commits
- 21files changed
- 1contributor
Commits on Aug 19, 2025
[release-branch.0.25] all: update codereview.cfg for release-branch.0.25
Forgolang/go#74462Change-Id: I180d4c99020745623602d315ddbd16ae94471610Reviewed-on:https://go-review.googlesource.com/c/tools/+/697415Reviewed-by: Peter Weinberger <pjw@google.com>TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
[release-branch.0.25] internal/tokeninternal: move unsafe gopls code …
…into goplsIn x/tools@v0.25.0, the tokeninternal package accessed the token.FileSetunsafely, and used a trick to force the build to break if ever the sizeof token.FileSet changed. This workaround was only necessary for gopls,but was unfortunately implemented in a package that was reachablethrough the public API of x/tools.In go1.25, the size of the token.FileSet changed, breaking tools thatindirectly depended on this poisoned package. Fix this by moving thegopls logic into gopls: the gopls build will still be broken, but thatdoesn't matter as we only support the most recent version of gopls,which is fixed.Forgolang/go#74462Change-Id: Ied3f7a615cab66d88ec6f4cfe8738f8429865993Reviewed-on:https://go-review.googlesource.com/c/tools/+/697336Reviewed-by: Peter Weinberger <pjw@google.com>TryBot-Bypass: Robert Findley <rfindley@google.com>Reviewed-on:https://go-review.googlesource.com/c/tools/+/697416Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
[release-branch.0.25] gopls: fix the build with go1.25
Turn the compile-time error in AddExistingFiles into a runtime panic,and avoid it by delegating to the FileSet.AddExistingFiles method ongo1.25.Also disable broken tests. Fewer test were broken here than inrelease-branch.0.24, because this branch include support for the newexport data.forgolang/go#74462Change-Id: I430209b329ab88da676253e2bf5f66d1792078bdReviewed-on:https://go-review.googlesource.com/c/tools/+/697339LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>Reviewed-by: Peter Weinberger <pjw@google.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 30def9c...789ea55
Uh oh!
There was an error while loading.Please reload this page.