NotificationsYou must be signed in to change notification settings
Fork158
Star897

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.

base repository:golang/sync

Failed to load repositories. Confirm that selected base ref is valid, then try again.

base:v0.10.0

Choose a base ref

...

head repository:golang/sync

Failed to load repositories. Confirm that selected head ref is valid, then try again.

compare:v0.11.0

Choose a head ref

1commit
1file changed
1contributor

Commits on Jan 17, 2025

sync/errgroup: improve documentation for semaphore limit behavior

Updated the documentation for `SetLimit` and `Go` functions in the`errgroup` package. the note clarifies the behavior when the semaphorelimit is set to zero, which could lead to a deadlock if not handledproperly. the updated documentation warns users to set a positivesemaphore limit to avoid blocking goroutines and potential deadlockthis change improves the clarity of API and helps users understand howto properly use the semaphore limit to prevent issues in concurrentexecutionChange-Id: Ie62acc38ef804b3590c04bddba00a3cce21e8cefReviewed-on:https://go-review.googlesource.com/c/sync/+/642215Reviewed-by: Michael Knyszek <mknyszek@google.com>LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Ian Lance Taylor <iant@google.com>Auto-Submit: Ian Lance Taylor <iant@google.com>