- Notifications
You must be signed in to change notification settings - Fork158
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:golang/sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:10739b0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:golang/sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:59c1ca1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 1commit
- 1file changed
- 1contributor
Commits on Dec 7, 2023
errgroup: add reference to sync.WaitGroup
Add doc link to sync.WaitGroup in the package documentation.Rationale:The reference to sync.WaitGroup might be obvious to the authors of thispackage, but it wasn't to me, so despites I had seen this packagemultiple times I had never made the link to sync.WaitGroup. So whenplaying with WaitGroup I was missing remembering about errgroup.In hope this will help others as well as my future self.Change-Id: I2c56976958ad9ab94c1596c96fa86c00dd73d2fbReviewed-on:https://go-review.googlesource.com/c/sync/+/538335Reviewed-by: Bryan Mills <bcmills@google.com>Reviewed-by: Carlos Amedee <carlos@golang.org>Auto-Submit: Bryan Mills <bcmills@google.com>LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 10739b0...59c1ca1
Uh oh!
There was an error while loading.Please reload this page.