Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/netPublic

http2: add support to configure transport flow control values#201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
joliveirinha wants to merge1 commit intogolang:master
base:master
Choose a base branch
Loading
fromjoliveirinha:joliveirinha/configurable-transport-values

Conversation

@joliveirinha
Copy link

Adds to the transport configuration the capability to configure the maximum flow control values instead of using default ones.
For applications that use a lot of client connections, being able to configure these values allows for better control on memory usage, particulary when connections are long-lived.

related:golang/go#20448

@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Adds to the transport configuration the capability to configure the maximum flow control valuesinstead of using default ones.For applications that use a lot of client connections, being able to configure these valuesallows for better control on memory usage, particulary when connections are long-lived.related:golang/go#20448
@joliveirinhajoliveirinhaforce-pushed thejoliveirinha/configurable-transport-values branch from2aaa1ad to76a4945CompareJanuary 15, 2024 13:42
@gopherbot
Copy link
Contributor

This PR (HEAD:76a4945) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/net/+/555835.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/555835.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message fromtricium-prod@appspot.gserviceaccount.com:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/555835.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. Seehttps://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visitgolang.org/cl/555835.
After addressing review feedback, remember topublish your drafts!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@kmk142789kmk142789kmk142789 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joliveirinha@gopherbot@jcsf@kmk142789

[8]ページ先頭

©2009-2025 Movatter.jp