- Notifications
You must be signed in to change notification settings - Fork1.2k
Comparing changes
Open a pull request
base repository:golang/net
Uh oh!
There was an error while loading.Please reload this page.
base:v0.20.0
head repository:golang/net
Uh oh!
There was an error while loading.Please reload this page.
compare:v0.21.0
- 7commits
- 11files changed
- 7contributors
Commits on Jan 8, 2024
quic: avoid deadlock in Endpoint.Close
Don't hold Endpoint.connsMu while calling Conn methods that canindirectly depend on acquiring it.Also change test cleanup to not wait for connections to drainwhen closing a test Endpoint, removing an unnecessary 0.1s delayin test runtime.Fixesgolang/go#64982.Change-Id: If336e63b0a7f5b8d2ef63986d36f9ee38a92c477Reviewed-on:https://go-review.googlesource.com/c/net/+/554695Reviewed-by: Jonathan Amsterdam <jba@google.com>LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
neild committedJan 8, 2024
Commits on Jan 10, 2024
http2: remove suspicious uint32->v conversion in frame code
Function maxHeaderStringLen(...) uses uint32(int(v)) == v check to validateif length will fit in the int type.This check is a no-op on any architecture because int type always has atleast 32 bits, so we can potentially encounter negative return values frommaxHeaderStringLen(...) function. This can be bad as this outcome clearlybreaks code intention and maybe some further code invariants.This patch replaces uint32(int(v)) == v check with more robust and simplerint(v) > 0 validation which is correct for our case when we operating withuint32Fixesgolang/go#64961Change-Id: I31f95709df9d25593ade3200696ac5cef9f88652Reviewed-on:https://go-review.googlesource.com/c/net/+/554235Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>Reviewed-by: Damien Neil <dneil@google.com>LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Commits on Jan 22, 2024
http2: avoid goroutine starvation in TestServer_Push_RejectAfterGoAway
CL 557037 added a runtime.Gosched to prevent goroutine starvationin the wasm fake-net stack. Unfortunately, that Gosched causes thescheduler to enter a very similar starvation loop in this test.Add another runtime.Gosched to break this new loop.Forgolang/go#65178.Change-Id: I24b3f50dd728800462f71f27290b0d8f99d5ae5bCq-Include-Trybots: luci.golang.try:x_net-gotip-wasip1-wasm_wasmtime,x_net-gotip-wasip1-wasm_wazero,x_net-gotip-js-wasmReviewed-on:https://go-review.googlesource.com/c/net/+/557615Auto-Submit: Bryan Mills <bcmills@google.com>LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Michael Pratt <mpratt@google.com>
Commits on Jan 31, 2024
VantageClient -> VantageServerChange-Id: Ie9738cffb06f03f961815853247e6f9cbe7fe466GitHub-Last-Rev:5d440adGitHub-Pull-Request:#202Reviewed-on:https://go-review.googlesource.com/c/net/+/555795LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Michael Knyszek <mknyszek@google.com>Reviewed-by: Damien Neil <dneil@google.com>Auto-Submit: Damien Neil <dneil@google.com>
Commits on Feb 3, 2024
dns/dnsmessage: allow name compression for SRV resource parsing
As per RFC 3597:Receiving servers MUST decompress domain names in RRs of well-known type, and SHOULD also decompress RRs of type RP, AFSDB, RT, SIG, PX, NXT, NAPTR, and SRV (although the current specification of the SRV RR in RFC2782 prohibits compression, RFC2052 mandated it, and some servers following that earlier specification are still in use).This change allows SRV resource decompression.Updatesgolang/go#36718Updatesgolang/go#37362Change-Id: I473c0d3803758e5b12886f378d2ed54bd5392144GitHub-Last-Rev:88d2e06GitHub-Pull-Request:#199Reviewed-on:https://go-review.googlesource.com/c/net/+/540375LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Carlos Amedee <carlos@golang.org>Auto-Submit: Damien Neil <dneil@google.com>Reviewed-by: Damien Neil <dneil@google.com>
Commits on Feb 7, 2024
html: fix SOLIDUS '/' handling in attribute parsing
Calling the Tokenizer with HTML elements containing SOLIDUS (/) characterin the attribute name results in incorrect tokenization.This is due to violation of the following rule transitions in the WHATWG spec:-https://html.spec.whatwg.org/multipage/parsing.html#attribute-name-state, where we are not reconsuming the character if '/' is encountered-https://html.spec.whatwg.org/multipage/parsing.html#after-attribute-name-state, where we are not switching to self closing stateFixesgolang/go#63402Change-Id: I90d998dd8decde877bd63aa664f3657aa6161024GitHub-Last-Rev:3546db8GitHub-Pull-Request:#195Reviewed-on:https://go-review.googlesource.com/c/net/+/533518LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Auto-Submit: Michael Pratt <mpratt@google.com>Reviewed-by: Roland Shoemaker <roland@golang.org>Reviewed-by: David Chase <drchase@google.com>
go.mod: update golang.org/x dependencies
Update golang.org/x dependencies to their latest tagged versions.Change-Id: I314af161ceac84fec04c729a71860ad35335513bReviewed-on:https://go-review.googlesource.com/c/net/+/562495Auto-Submit: Gopher Robot <gobot@golang.org>Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Than McIntosh <thanm@google.com>
gopherbot committedFeb 7, 2024
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v0.20.0...v0.21.0
Uh oh!
There was an error while loading.Please reload this page.