- Notifications
You must be signed in to change notification settings - Fork1.2k
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:66e838c
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:e2310ae
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 3commits
- 6files changed
- 3contributors
Commits on Jun 12, 2024
http2: avoid Transport hang with Connection: close and AllowHTTP
CL 111835 changed Transport stream ID numbering to start atstream 3 when AllowHTTP is set. This was based on amisunderstanding:When a connection upgrades an HTTP/1.1 request to HTTP/2,the initial HTTP/1.1 request occupies stream 1.However, Transport does not perform HTTP protocol upgrades.When using a Transport to send unencrypted HTTP/2 requests,the entire connection uses HTTP/2, the first request issent as HTTP/2, and there is no reason not to use stream 1for this request.Starting from stream 3 is mostly harmless,but ClientConn.idleStateLocked assumes that client streamsstart from 1. This causes it to misidentify new single-useconnections as having already sent a request (when AllowHTTPis set), and therefore not suitable for use.Revert to always starting stream IDs at 1.Fixesgolang/go#67671Change-Id: I97c89de4ae49623d916f9dbd200f8252d2fd4247Reviewed-on:https://go-review.googlesource.com/c/net/+/591275LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Jonathan Amsterdam <jba@google.com>
Commits on Jul 5, 2024
quic: skip tests which depend on unimplemented UDP functions on Plan 9
The ReadMsgUDP and WriteMsgUDP methods of UDPConn are not implemented(yet?) on Plan 9. Skip tests which require them.Fixesgolang/go#68288Change-Id: Ic6c81b19322d589c10b16da61e9b89284294be05Reviewed-on:https://go-review.googlesource.com/c/net/+/596795Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Than McIntosh <thanm@google.com>
go.mod: update golang.org/x dependencies
Update golang.org/x dependencies to their latest tagged versions.Change-Id: Ibb0ab46488252d035430a654eed5dd4caab7509eReviewed-on:https://go-review.googlesource.com/c/net/+/596895LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Auto-Submit: Gopher Robot <gobot@golang.org>Reviewed-by: Than McIntosh <thanm@google.com>Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 66e838c...e2310ae
Uh oh!
There was an error while loading.Please reload this page.