NotificationsYou must be signed in to change notification settings
Fork1.2k
Star3k

Commit5d5a036

committed

quic: handle streams moving from the data queue to the meta queue

In Conn.appendStreamFrames, a stream can be moved from thedata queue (for streams with only flow-controlled frames to send)to the metadata queue (for streams with non-flow-controlled framesto send) if some other goroutine asynchronously modifies thestream state.Adjust the check at the end of this function to clear the needSendbool only if queueMeta and queueData are both empty, to avoidlosing track of the need to send frames when this happens.Forgolang/go#58547Change-Id: Ib9ad3b01f543cd7673f5233ceb58b2db9adfff5aReviewed-on:https://go-review.googlesource.com/c/net/+/531656LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>Reviewed-by: Jonathan Amsterdam <jba@google.com>

1 parent350aad2 commit5d5a036Copy full SHA for 5d5a036

File tree

1 file changed

-1

lines changed

internal/quic
- conn_streams.go

1 file changed

-1

lines changed

`‎internal/quic/conn_streams.go‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,9 @@ func (c Conn) appendStreamFrames(w packetWriter, pnum packetNumber, pto bool)`
`372`	`372`	`state=s.state.set(0,streamQueueData)`
`373`	`373`	`c.queueStreamForSendLocked(s,state)`
`374`	`374`	`}`
`375`		`-c.streams.needSend.Store(c.streams.queueData.head!=nil)`
	`375`	`+ifc.streams.queueMeta.head==nil&&c.streams.queueData.head==nil {`
	`376`	`+c.streams.needSend.Store(false)`
	`377`	`+}`
`376`	`378`	`returntrue`
`377`	`379`	`}`
`378`	`380`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5d5a036

File tree

1 file changed

1 file changed

`‎internal/quic/conn_streams.go‎`

0 commit comments