Commite85016f

committed

database/sql: remove an unused field from Rows

Found while debugging memory usage. Nobody accesses this fieldanymore.R=golang-dev, i.caught.air, adg, rCC=golang-devhttps://golang.org/cl/9108043

1 parent61dbc34 commite85016fCopy full SHA for e85016f

File tree

-4

lines changed

-4

lines changed

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -735,7 +735,6 @@ func (db DB) queryConn(dc driverConn, releaseConn func(error), query string, a`
`735`	`735`	`// Note: ownership of dc passes to the *Rows, to be freed`
`736`	`736`	`// with releaseConn.`
`737`	`737`	`rows:=&Rows{`
`738`		`-db:db,`
`739`	`738`	`dc:dc,`
`740`	`739`	`releaseConn:releaseConn,`
`741`	`740`	`rowsi:rowsi,`
`@@ -765,7 +764,6 @@ func (db DB) queryConn(dc driverConn, releaseConn func(error), query string, a`
`765`	`764`	`// Note: ownership of ci passes to the *Rows, to be freed`
`766`	`765`	`// with releaseConn.`
`767`	`766`	`rows:=&Rows{`
`768`		`-db:db,`
`769`	`767`	`dc:dc,`
`770`	`768`	`releaseConn:releaseConn,`
`771`	`769`	`rowsi:rowsi,`
`@@ -1181,7 +1179,6 @@ func (s Stmt) Query(args ...interface{}) (Rows, error) {`
`1181`	`1179`	`// Note: ownership of ci passes to the *Rows, to be freed`
`1182`	`1180`	`// with releaseConn.`
`1183`	`1181`	`rows:=&Rows{`
`1184`		`-db:s.db,`
`1185`	`1182`	`dc:dc,`
`1186`	`1183`	`rowsi:rowsi,`
`1187`	`1184`	`// releaseConn set below`
`@@ -1286,7 +1283,6 @@ func (s *Stmt) finalClose() error {`
`1286`	`1283`	`// err = rows.Err() // get any error encountered during iteration`
`1287`	`1284`	`// ...`
`1288`	`1285`	`typeRowsstruct {`
`1289`		`-db*DB`
`1290`	`1286`	`dc*driverConn// owned; must call releaseConn when closed to release`
`1291`	`1287`	`releaseConnfunc(error)`
`1292`	`1288`	`rowsi driver.Rows`

Comments

(0)