NotificationsYou must be signed in to change notification settings
Fork18.4k
Star130k

Commit0752bc8

committed

[release-branch.go1.3] runtime: fix nacl amd64p32 flakiness

««« CL 102710043 / 5640e19d768druntime: fix nacl amd64p32 flakinessnewproc takes two extra pointers, not two extra registers.On amd64p32 (nacl) they are different.We diagnosed this before the 1.3 cut but the tree was frozen.I believe this is causing the random problems on the builder.Fixes#8199.TBR=rCC=golang-codereviewshttps://golang.org/cl/102710043»»»TBR=rscCC=golang-codereviewshttps://golang.org/cl/124120044

1 parent329d3ce commit0752bc8Copy full SHA for 0752bc8

File tree

1 file changed

-1

lines changed

src/pkg/runtime
- traceback_x86.c

1 file changed

-1

lines changed

`‎src/pkg/runtime/traceback_x86.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ runtime·gentraceback(uintptr pc0, uintptr sp0, uintptr lr0, G *gp, int32 skip,`
`214`	`214`	`// the SP is two words lower than normal.`
`215`	`215`	`sparg=frame.sp;`
`216`	`216`	`if(wasnewproc)`
`217`		`-sparg+=2*sizeof(uintreg);`
	`217`	`+sparg+=2*sizeof(uintptr);`
`218`	`218`
`219`	`219`	`// Determine frame's 'continuation PC', where it can continue.`
`220`	`220`	`// Normally this is the return address on the stack, but if sigpanic`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0752bc8

File tree

1 file changed

1 file changed

`‎src/pkg/runtime/traceback_x86.c‎`

0 commit comments