Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Introduce RegisterReaderHandlerWithEncoderInfo#1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Jille wants to merge1 commit intogo-sql-driver:master
base:master
Choose a base branch
Loading
fromJille:reader-config

Conversation

Jille
Copy link

@JilleJille commentedApr 25, 2023•
edited
Loading

Description

Introduce RegisterReaderHandlerWithEncoderInfo

It is the same as RegisterReaderHandler, but receives some configuration
settings which are needed to correctly encode the TSV. (For now only the
Location).

for issue#1416

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

dolmen reacted with thumbs down emoji
It is the same as RegisterReaderHandler, but receives some configurationsettings which are needed to correctly encode the TSV. (For now only theLocation).issuego-sql-driver#1416
@JilleJille changed the titleIntroduce RegisterReaderHandlerWithConfigIntroduce RegisterReaderHandlerWithEncoderInfoApr 26, 2023
@methanemethane marked this pull request as draftMay 27, 2023 17:09
@dolmen
Copy link
Contributor

You are not saying why thetime.Location of the DSN is useful for encoding the TSV.

Some example code (ideally provided as atestable example) would be helpful for review as well as for end users.

@dolmen
Copy link
Contributor

dolmen commentedJun 2, 2023•
edited
Loading

See@methane comment in#1416 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Jille@dolmen
[8]ページ先頭
©2009-2025 Movatter.jp