Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
refactor: extract helper functions from SearchIssues#36158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bimakw wants to merge1 commit intogo-gitea:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+89 −81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Extract parseIssueIsClosed, parseIssueIsPull, and buildSearchIssuesRepoIDshelper functions to improve code readability and maintainability.- parseIssueIsClosed: parses "state" query parameter- parseIssueIsPull: parses "type" query parameter- buildSearchIssuesRepoIDs: builds repository IDs for issue searchAlso consolidate error handling conditions using || operator.
e04b0bd to8909fceCompareAuthor
bimakw commentedDec 18, 2025
Thanks@lunny for the review! Updated to use |
lunny approved these changesDec 18, 2025
| iferr!=nil { | ||
| repoIDs,allPublic,err:=buildSearchIssuesRepoIDs(ctx) | ||
| iferr!=nil { | ||
| ifuser_model.IsErrUserNotExist(err)||organization.IsErrTeamNotExist(err)||err.Error()=="owner organisation is required for filtering on team" { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
err.Error() == "owner organisation is required for filtering on team"
please don't do this, it is an abuse to Golang error system and is very fragile.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
lgtm/need 1This PR needs approval from one additional maintainer to be merged. modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
SearchIssuesfunction inrouters/api/v1/repo/issue.goby extracting common logic into reusable helper functions:parseIssueIsClosed(): Parses the "state" query parameter and returns the correspondingisClosedoptionparseIssueIsPull(): Parses the "type" query parameter and returns the correspondingisPulloptionbuildSearchIssuesRepoIDs(): Builds the list of repository IDs for issue search based on query parametersBenefits:
Changes:
SearchIssuesfunctionTest plan
/repos/issues/searchendpointRef:#35015