Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
fix some file icon ui#36078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix some file icon ui#36078
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fixgo-gitea#36071looks that's because if an svg in hiden env, it's coloradded by `fill="url(#a)"` will become not usefull. by ai helping,I think moving it out of page by position is a good solution.fell free creat a new pull request if you have a better soluton.Thanks.Signed-off-by: a1012112796 <1012112796@qq.com>
silverwind commentedDec 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Interesting bug. I can reproduce on Chrome and Safari, but not on Firefox. I think the root cause must be some obscure mechanism where some SVG elements like this I can't think of a better fix, but please move this CSS into .hide-absolute {position: absolute;left:-9999px;} |
wxiaoguang commentedDec 3, 2025
silverwind commentedDec 4, 2025
You mean the styling of |
wxiaoguang commentedDec 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I didn't say "same". I mean "similar":
For this case, these styles work without magic number: |
silverwind commentedDec 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Generally speaking I would avoid SVG "icon maps" with |
silverwind commentedDec 4, 2025
Oh and btw, |
wxiaoguang commentedDec 4, 2025
It should be easy to remove the |
silverwind commentedDec 4, 2025
I don't think the size impact will really matter. On a big page, there may be 100 icons, which shouldn't be more than a few kBs. |
wxiaoguang commentedDec 4, 2025
![]() |
wxiaoguang commentedDec 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
ee365f5 intogo-gitea:mainUh oh!
There was an error while loading.Please reload this page.
fixgo-gitea#36071looks that's because if an svg in hiden env, it's color added by`fill="url(#a)"` will become not usefull. by ai helping, I think movingit out of page by position is a good solution. fell free creat a newpull request if you have a better soluton. Thanks.<img width="2198" height="1120" alt="image"src="https://github.com/user-attachments/assets/bbf7c171-0b7f-412a-a1bc-aea3f1629636"/>---------Signed-off-by: a1012112796 <1012112796@qq.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport#36078 by@a1012112796fix#36071looks that's because if an svg in hiden env, it's color added by`fill="url(#a)"` will become not usefull. by ai helping, I think movingit out of page by position is a good solution. fell free creat a newpull request if you have a better soluton. Thanks.<img width="2198" height="1120" alt="image"src="https://github.com/user-attachments/assets/bbf7c171-0b7f-412a-a1bc-aea3f1629636"/>Signed-off-by: a1012112796 <1012112796@qq.com>Co-authored-by: a1012112796 <1012112796@qq.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* giteaofficial/main: Add strikethrough button to markdown editor (go-gitea#36087) Move commit related functions to gitrepo package (go-gitea#35600) Fix the bug when ssh clone with redirect user or repository (go-gitea#36039) fix some file icon ui (go-gitea#36078) update golangci-lint to v2.7.0 (go-gitea#36079) Use Golang net/smtp instead of gomail's smtp to send email (go-gitea#36055) Fix edit user email bug in API (go-gitea#36068) [skip ci] Updated translations via Crowdin


fix#36071
looks that's because if an svg in hiden env, it's color added by

fill="url(#a)"will become not usefull. by ai helping, I think moving it out of page by position is a good solution. fell free creat a new pull request if you have a better soluton. Thanks.