Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor reverseproxy configuration#36056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lunny wants to merge1 commit intogo-gitea:main
base:main
Choose a base branch
Loading
fromlunny:lunny/reverseproxy_cfg

Conversation

@lunny
Copy link
Member

image

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelNov 29, 2025
@github-actionsgithub-actionsbot added modifies/translation modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files labelsNov 29, 2025
@lunnylunny added type/refactoringExisting code has been cleaned up. There should be no new functionality. and removed modifies/translation modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files labelsNov 29, 2025
@lunnylunny added this to the1.26.0 milestoneNov 29, 2025
Copy link
Contributor

@wxiaoguangwxiaoguang left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ref:#35962 (comment)

And you are just wasting time:#32145 (comment)

I have told you dozens of time, you need to completely refactor the config system, but not keep adding more fragile patches.

There are hundreds of config options.

Without a complete design, the "config" page shouldn't show anything more.

What users really need is to lint the config file and find mistakes, but not read a page which is filled by hundreds of config options again.

@GiteaBotGiteaBot added lgtm/blockedA maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsNov 29, 2025
@lunny
Copy link
MemberAuthor

lunny commentedNov 29, 2025•
edited
Loading

This PR is a small step toward providing full reverse-proxy information in the configuration page, rather than only handling the authenticated user. I don’t see how it would block or prevent a full refactor in the future.

What users really need is to lint the config file and find mistakes, but not read a page which is filled by hundreds of config options again.

I know many users need to know the configurations or change the configurations from the UI and they cannot visit the app.ini directly.

@wxiaoguang
Copy link
Contributor

This PR is a small step toward providing full reverse-proxy information in the configuration page, rather than only handling the authenticated user. I don’t see how it would block or prevent a full refactor in the future.

It doesn't block, but it is not right (still has bugs) and wastes time.

I know many users need to know the configurations or change the configurations from the UI and they cannot visit the app.ini directly.

It's not related to "show hundreds of config options on the UI"

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wxiaoguangwxiaoguangwxiaoguang requested changes

Assignees

No one assigned

Labels

lgtm/blockedA maintainer has reservations with the PR and thus it cannot be mergedtype/refactoringExisting code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Admin interface: config summary shows unused option

3 participants

@lunny@wxiaoguang@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp