NotificationsYou must be signed in to change notification settings
Fork6.3k
Star52.6k

Display source code downloads last for release attachments#35897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

techknowlogick merged 2 commits intogo-gitea:mainfromlutinglt:patch-1

Nov 8, 2025

Merged

Display source code downloads last for release attachments#35897

techknowlogick merged 2 commits intogo-gitea:mainfromlutinglt:patch-1

Nov 8, 2025

Conversation

Copy link

Contributor

lutinglt commentedNov 8, 2025•
edited by delvh
Loading

Typically, you want to download the binaries, not the source code.

Re-add source code download links for releases

6e46a70

Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>

GiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. label

Nov 8, 2025

github-actionsbot added the modifies/templatesThis PR modifies the template files label

Nov 8, 2025

lutinglt changed the title~~Perf: Adjust the order of attachments in the download list~~Adjust the order of attachments in the download list

Nov 8, 2025

Copy link

Member

delvh commentedNov 8, 2025

Could you post some screenshots how it looks now?

Copy link

ContributorAuthor

lutinglt commentedNov 8, 2025•
edited
Loading

Could you post some screenshots how it looks now?

I used my own theme, which is Gitea 1.25.1 version. The effect is to directly apply the new template using the templates directory

Pay attention to the priority of rustack attachments. Attachments uploaded in the distribution have a higher priority than the source code

before:

after:

wxiaoguang approved these changes

Nov 8, 2025

View reviewed changes

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labels

Nov 8, 2025

wxiaoguang added backport/v1.25 type/enhancementAn improvement of existing functionality labels

Nov 8, 2025

delvh changed the title~~Adjust the order of attachments in the download list~~Display source code downloads last for release attachments

Nov 8, 2025

delvh approved these changes

Nov 8, 2025

View reviewed changes

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labels

Nov 8, 2025

Copy link

Member

delvh commentedNov 8, 2025

Thanks, due to the screenshots, I now know what you mean.
Completely agree, I've thought about the same thing already.

delvh added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. label

Nov 8, 2025

Merge branch 'main' into patch-1

2a98bfd

techknowlogickenabled auto-merge (squash)

November 8, 2025 15:55

techknowlogick merged commit367a289 intogo-gitea:main

Nov 8, 2025

25 checks passed

GiteaBot added this to the1.26.0 milestone

Nov 8, 2025

GiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. label

Nov 8, 2025

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request

Nov 8, 2025

Display source code downloads last for release attachments (go-gitea#…

1a4a9e7

…35897)

GiteaBot mentioned this pull request

Nov 8, 2025

Display source code downloads last for release attachments (#35897)#35903

Merged

GiteaBot added the backport/doneAll backports for this PR have been created label

Nov 8, 2025

lutinglt deleted the patch-1 branch

November 9, 2025 01:14

wxiaoguang pushed a commit that referenced this pull request

Nov 9, 2025

Display source code downloads last for release attachments (#35897) (#…

2b71bf2

…35903)Backport#35897 by lutingltTypically, you want to download the binaries, not the source code.Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

zjjhot added a commit to zjjhot/gitea that referenced this pull request

Nov 10, 2025

Merge remote-tracking branch 'giteaofficial/main'

079ad07

* giteaofficial/main:  Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (go-gitea#35882)  Add proper page title for project pages (go-gitea#35773)  Use correct form field for allowed force push users in branch protection API (go-gitea#35894)  Fix team member access check (go-gitea#35899)  Add ability for local makefile with personal customizations that wouldnt affect remote repo (go-gitea#35836)  Add toolchain directive to go.mod (go-gitea#35901)  Display source code downloads last for release attachments (go-gitea#35897)  Fix conda null depend issue (go-gitea#35900)  Fix avatar upload error handling (go-gitea#35887)  Move `gitea-vet` to use `go tool` (go-gitea#35878)  Contribution heatmap improvements (go-gitea#35876)  Update to go 1.25.4 (go-gitea#35877)

zjjhot added a commit to zjjhot/gitea that referenced this pull request

Nov 24, 2025

Merge remote-tracking branch 'giteaofficial/release/v1.25'

0a09b13

* giteaofficial/release/v1.25: (77 commits)  Add "site admin" back to profile menu (go-gitea#36010) (go-gitea#36013)  release notes for 1.25.2 (go-gitea#35986)  Allow empty commit when merging pull request with squash style (go-gitea#35989) (go-gitea#36003)  Fix various permission & login related bugs (go-gitea#36002) (go-gitea#36004)  upgrade golang.org/x/crypto to 0.45.0 (go-gitea#35988)  Change project default column icon to 'star' (go-gitea#35967) (go-gitea#35979)  Misc CSS fixes (go-gitea#35888) (go-gitea#35981)  Fix container push tag overwriting (go-gitea#35936) (go-gitea#35954)  Fix corrupted external render content (go-gitea#35946) (go-gitea#35950)  Don't show unnecessary error message to end users for DeleteBranchAfterMerge (go-gitea#35937) (go-gitea#35941)  Limit read bytes instead of ReadAll (go-gitea#35928) (go-gitea#35934)  Load jQuery as early as possible to support custom scripts (go-gitea#35926) (go-gitea#35929)  Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (go-gitea#35882) (go-gitea#35917)  Use correct form field for allowed force push users in branch protection API (go-gitea#35894) (go-gitea#35908)  Make OAuth2 issuer configurable (go-gitea#35915) (go-gitea#35916)Fixgo-gitea#35763: Add proper page title for project pages (go-gitea#35773) (go-gitea#35909)  Display source code downloads last for release attachments (go-gitea#35897) (go-gitea#35903)  Fix team member access check (go-gitea#35899) (go-gitea#35905)  Fix conda null depend issue (go-gitea#35900) (go-gitea#35902)  Fix avatar upload error handling (go-gitea#35887) (go-gitea#35890)  ...# Conflicts:#go.mod#go.sum#models/actions/run_test.go#models/fixtures/action_run.yml#models/fixtures/action_run_job.yml#models/fixtures/action_task.yml#models/fixtures/branch.yml#models/fixtures/repo_unit.yml#modules/git/tree_entry_gogit.go#modules/git/tree_gogit.go#routers/web/repo/actions/view.go#routers/web/repo/issue_comment.go#services/actions/workflow.go#services/doctor/actions_test.go#services/pull/comment.go#services/pull/pull.go#services/pull/temp_repo.go#templates/base/head_navbar.tmpl#templates/swagger/v1_json.tmpl#tests/integration/actions_schedule_test.go#tests/integration/git_lfs_ssh_test.go#tests/integration/pull_create_test.go#tests/integration/pull_merge_test.go#tests/sqlite.ini.tmpl#web_src/js/components/ContextPopup.vue