Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Fix circular spin animation direction#35785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
silverwind approved these changesOct 30, 2025
Contributor
wxiaoguang commentedOct 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Please read and fix the comment  |
ContributorAuthor
lutinglt commentedOct 30, 2025
Now, we have our own icon that can rotate clockwise ( |
Contributor
wxiaoguang commentedOct 30, 2025
@silverwind what do you think about the new change? It looks good to me. |
ContributorAuthor
lutinglt commentedOct 30, 2025
I have a better idea. 'octicon sync' is a counterclockwise icon used to represent the state of rollback or rerun. If it is a rollback or rerun, we should use a counterclockwise icon and a counterclockwise rotation animation. If it is ongoing, first-time, or one-time execution, we should use a clockwise icon and a clockwise rotation animation. This can be a bit troublesome because I am not very clear about the specific purpose of some pages. |
Contributor
wxiaoguang commentedOct 30, 2025
Maybe no need to make it that complex. When it is a static icon, I guess few people would really look carefully at it to see whether it is clockwise or counterclockwise |
ContributorAuthor
lutinglt commentedOct 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
  Emmm, Maybe it's still quite obvious?   |
Member
silverwind commentedOct 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
ContributorAuthor
lutinglt commentedOct 30, 2025
I agree, but I can't see the specific page. It seems like there's no problem looking at the code? If possible, I will modify and submit it like this. |
Member
silverwind commentedOct 30, 2025
Should be safe to replace "blindly" if the icon size is the same. |
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
ContributorAuthor
lutinglt commentedOct 31, 2025
The viewBox for |
silverwind approved these changesOct 31, 2025
lunny approved these changesNov 2, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull requestNov 2, 2025
Wait for the status icon to rotate clockwise instead of counterclockwisebefore:after:---------Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>Co-authored-by: lutinglt <lutinglt@users.noreply.github.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
f2d7931 intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
zjjhot added a commit to zjjhot/gitea that referenced this pull requestNov 3, 2025
* giteaofficial/main: Add cache to container build (go-gitea#35697) Revert gomail to v0.7.0 to fix sending mail failed (go-gitea#35816) Fix circular spin animation direction (go-gitea#35785) Fix clone mixed bug (go-gitea#35810) [skip ci] Updated translations via Crowdin Remove unnecessary function parameter (go-gitea#35765) Fix cli "Before" handling (go-gitea#35797) Add test for ExtendCommentTreePathLength migration and fix bugs (go-gitea#35791) Fix file extension on gogs.png (go-gitea#35793) Improve and fix markup code preview rendering (go-gitea#35777)
silverwind pushed a commit that referenced this pull requestNov 3, 2025
Backport#35785 by@lutingltWait for the status icon to rotate clockwise instead of counterclockwisebefore:after:This can be merged to 1.25Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>Co-authored-by: lutinglt <lutinglt@users.noreply.github.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
project-mirrors-bot-tubot pushed a commit to project-mirrors/gitea-helm-chart that referenced this pull requestNov 5, 2025
This PR contains the following updates:| Package | Update | Change ||---|---|---|| [go-gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.25.0` -> `1.25.1` |---### Release Notes<details><summary>go-gitea/gitea (go-gitea/gitea)</summary>### [`v1.25.1`](https://github.com/go-gitea/gitea/releases/tag/v1.25.1)[Compare Source](go-gitea/gitea@v1.25.0...v1.25.1)- BUGFIXES - Make ACME email optional ([#​35849](go-gitea/gitea#35849)) [#​35857](go-gitea/gitea#35857) - Add a doctor command to fix inconsistent run status ([#​35840](go-gitea/gitea#35840)) ([#​35845](go-gitea/gitea#35845)) - Remove wrong code ([#​35846](go-gitea/gitea#35846)) - Fix viewed files number is not right if not all files loaded ([#​35821](go-gitea/gitea#35821)) ([#​35844](go-gitea/gitea#35844)) - Fix incorrect pull request counter ([#​35819](go-gitea/gitea#35819)) ([#​35841](go-gitea/gitea#35841)) - Upgrade go mail to 0.7.2 and fix the bug ([#​35833](go-gitea/gitea#35833)) ([#​35837](go-gitea/gitea#35837)) - Revert gomail to v0.7.0 to fix sending mail failed ([#​35816](go-gitea/gitea#35816)) ([#​35824](go-gitea/gitea#35824)) - Fix clone mixed bug ([#​35810](go-gitea/gitea#35810)) ([#​35822](go-gitea/gitea#35822)) - Fix cli "Before" handling ([#​35797](go-gitea/gitea#35797)) ([#​35808](go-gitea/gitea#35808)) - Improve and fix markup code preview rendering ([#​35777](go-gitea/gitea#35777)) ([#​35787](go-gitea/gitea#35787)) - Fix actions rerun bug ([#​35783](go-gitea/gitea#35783)) ([#​35784](go-gitea/gitea#35784)) - Fix actions schedule update issue ([#​35767](go-gitea/gitea#35767)) ([#​35774](go-gitea/gitea#35774)) - Fix circular spin animation direction ([#​35785](go-gitea/gitea#35785)) ([#​35823](go-gitea/gitea#35823)) - Fix file extension on gogs.png ([#​35793](go-gitea/gitea#35793)) ([#​35799](go-gitea/gitea#35799)) - Add pnpm to Snapcraft ([#​35778](go-gitea/gitea#35778))Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xOC4xIiwidXBkYXRlZEluVmVyIjoiNDEuMTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsia2luZC9kZXBlbmRlbmN5Il19-->Reviewed-on:https://gitea.com/gitea/helm-gitea/pulls/981Reviewed-by: Markus Pesch <volker.raschek@noreply.gitea.com>Co-authored-by: Renovate Bot <renovate-bot@gitea.com>Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
backport/doneAll backports for this PR have been created backport/v1.25lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontendmodifies/templatesThis PR modifies the template files
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Wait for the status icon to rotate clockwise instead of counterclockwise
before:
after:
This can be merged to 1.25