Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix actions rerun bug (#35783)#35784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Zettat123
Copy link
Contributor

@Zettat123Zettat123 commentedOct 30, 2025•
edited by wxiaoguang
Loading

Backport#35783

Fix#35780,fix#35782

Rerunning a job or a run is only allowed when the job is done and the run is done.

Related PR:#34970

resp.State.Run.CanRerun=run.Status.IsDone()&&ctx.Repo.CanWrite(unit.TypeActions)

We don't need to check run status again inrerunJob because the run status has been changed beforererunJob.

In fact, the bug described in the above issues will not occur on the main branch. BecausegetRunJobs is called before updating the run.

job,jobs:=getRunJobs(ctx,runIndex,jobIndex)
ifctx.Written() {
return
}
// reset run's start and stop time when it is done
ifrun.Status.IsDone() {
run.PreviousDuration=run.Duration()
run.Started=0
run.Stopped=0
run.Status=actions_model.StatusWaiting

So the run status thatrerunJob checks is the old status.

merlinz01 reacted with thumbs up emoji
Related issues:go-gitea#35780,go-gitea#35782Rerunning a job or a run is only allowed when the job is done and therun is done.Related PR:go-gitea#34970
@GiteaBotGiteaBot added this to the1.25.1 milestoneOct 30, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelOct 30, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelOct 30, 2025
@wxiaoguang
Copy link
Contributor

I think we can say "this PR fixes ..." now 😆

Zettat123, ZeroDeng01, and lutinglt reacted with thumbs up emojiNorthRealm, ZeroDeng01, and lutinglt reacted with eyes emoji

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsOct 30, 2025
@NorthRealm
Copy link
Contributor

Literally... 🤷

@ZeroDeng01
Copy link

I think we can say "this PR fixes ..." now 😆

Hope to release the patch successfully🧐

@wxiaoguang
Copy link
Contributor

I think we can say "this PR fixes ..." now 😆

Literally... 🤷

Hope to release the patch successfully🧐

I mean the bug doesn't really exist on main branch 😁

@ZeroDeng01
Copy link

I think we can say "this PR fixes ..." now 😆

Literally... 🤷
Hope to release the patch successfully🧐

I mean the bug doesn't really exist on main branch 😁

As you said, I temporarily switched to the main-nightly tag to keep the system running normally.

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsOct 30, 2025
@silverwindsilverwind merged commit04b6f90 intogo-gitea:release/v1.25Oct 30, 2025
26 checks passed
@wxiaoguangwxiaoguang deleted the backport/35783-to-v1.25 branchOctober 30, 2025 08:38
project-mirrors-bot-tubot pushed a commit to project-mirrors/gitea-helm-chart that referenced this pull requestNov 5, 2025
This PR contains the following updates:| Package | Update | Change ||---|---|---|| [go-gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.25.0` -> `1.25.1` |---### Release Notes<details><summary>go-gitea/gitea (go-gitea/gitea)</summary>### [`v1.25.1`](https://github.com/go-gitea/gitea/releases/tag/v1.25.1)[Compare Source](go-gitea/gitea@v1.25.0...v1.25.1)- BUGFIXES  - Make ACME email optional ([#&#8203;35849](go-gitea/gitea#35849)) [#&#8203;35857](go-gitea/gitea#35857)  - Add a doctor command to fix inconsistent run status ([#&#8203;35840](go-gitea/gitea#35840)) ([#&#8203;35845](go-gitea/gitea#35845))  - Remove wrong code ([#&#8203;35846](go-gitea/gitea#35846))  - Fix viewed files number is not right if not all files loaded ([#&#8203;35821](go-gitea/gitea#35821)) ([#&#8203;35844](go-gitea/gitea#35844))  - Fix incorrect pull request counter ([#&#8203;35819](go-gitea/gitea#35819)) ([#&#8203;35841](go-gitea/gitea#35841))  - Upgrade go mail to 0.7.2 and fix the bug ([#&#8203;35833](go-gitea/gitea#35833)) ([#&#8203;35837](go-gitea/gitea#35837))  - Revert gomail to v0.7.0 to fix sending mail failed ([#&#8203;35816](go-gitea/gitea#35816)) ([#&#8203;35824](go-gitea/gitea#35824))  - Fix clone mixed bug ([#&#8203;35810](go-gitea/gitea#35810)) ([#&#8203;35822](go-gitea/gitea#35822))  - Fix cli "Before" handling ([#&#8203;35797](go-gitea/gitea#35797)) ([#&#8203;35808](go-gitea/gitea#35808))  - Improve and fix markup code preview rendering ([#&#8203;35777](go-gitea/gitea#35777)) ([#&#8203;35787](go-gitea/gitea#35787))  - Fix actions rerun bug ([#&#8203;35783](go-gitea/gitea#35783)) ([#&#8203;35784](go-gitea/gitea#35784))  - Fix actions schedule update issue ([#&#8203;35767](go-gitea/gitea#35767)) ([#&#8203;35774](go-gitea/gitea#35774))  - Fix circular spin animation direction ([#&#8203;35785](go-gitea/gitea#35785)) ([#&#8203;35823](go-gitea/gitea#35823))  - Fix file extension on gogs.png ([#&#8203;35793](go-gitea/gitea#35793)) ([#&#8203;35799](go-gitea/gitea#35799))  - Add pnpm to Snapcraft ([#&#8203;35778](go-gitea/gitea#35778))Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xOC4xIiwidXBkYXRlZEluVmVyIjoiNDEuMTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsia2luZC9kZXBlbmRlbmN5Il19-->Reviewed-on:https://gitea.com/gitea/helm-gitea/pulls/981Reviewed-by: Markus Pesch <volker.raschek@noreply.gitea.com>Co-authored-by: Renovate Bot <renovate-bot@gitea.com>Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
@xnoxxnox mentioned this pull requestDec 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@silverwindsilverwindsilverwind approved these changes

@wxiaoguangwxiaoguangwxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/dependenciesmodifies/goPull requests that update Go codetype/bug

Projects

None yet

Milestone

1.25.1

Development

Successfully merging this pull request may close these issues.

Re-running of workflow stalls in "waiting" state, unable to cancel. Actions re-run not working in Gitea 1.25

6 participants

@Zettat123@wxiaoguang@NorthRealm@ZeroDeng01@silverwind@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp