Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Fix actions rerun bug#35783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Fix actions rerun bug#35783
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
wxiaoguang approved these changesOct 29, 2025
Contributor
wxiaoguang commentedOct 29, 2025
A lot of changes are 1.26 only, so maybe you need to manually backport the fix |
ContributorAuthor
Zettat123 commentedOct 29, 2025
Yes. I think the backport needs to be fixed manually. |
lunny approved these changesOct 30, 2025
3ab8ae5 intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Zettat123 added a commit to Zettat123/gitea that referenced this pull requestOct 30, 2025
Related issues:go-gitea#35780,go-gitea#35782Rerunning a job or a run is only allowed when the job is done and therun is done.Related PR:go-gitea#34970
mithileshgupta12 pushed a commit to mithileshgupta12/gitea that referenced this pull requestOct 30, 2025
Related issues:go-gitea#35780,go-gitea#35782 Rerunning a job or a run is only allowed when the job is done and therun is done.Related PR:go-gitea#34970
silverwind pushed a commit that referenced this pull requestOct 30, 2025
Backport#35783Fix#35780,fix#35782 Rerunning a job or a run is only allowed when the job is done and therun is done.Related PR:#34970https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L239We don't need to check run status again in `rerunJob` because the runstatus has been changed before `rerunJob`.---In fact, the bug described in the above issues will not occur on themain branch. Because `getRunJobs` is called before updating the run.https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L425-L435So the run status that `rerunJob` checks is the old status.---------Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
techknowlogick pushed a commit that referenced this pull requestNov 4, 2025
#35783 fixes an actions rerun bug. Due to this bug, some runs may beincorrectly marked as `StatusWaiting` even though all the jobs are indone status. These runs cannot be run or cancelled. This PR adds a newdoctor command to fix the inconsistent run status.```gitea doctor check --run fix-actions-unfinished-run-status --fix```Thanks to@ChristopherHX for the test.
lunny pushed a commit that referenced this pull requestNov 4, 2025
Backport#35840#35783 fixes an actions rerun bug. Due to this bug, some runs may beincorrectly marked as `StatusWaiting` even though all the jobs are indone status. These runs cannot be run or cancelled. This PR adds a newdoctor command to fix the inconsistent run status.```gitea doctor check --run fix-actions-unfinished-run-status --fix```
project-mirrors-bot-tubot pushed a commit to project-mirrors/gitea-helm-chart that referenced this pull requestNov 5, 2025
This PR contains the following updates:| Package | Update | Change ||---|---|---|| [go-gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.25.0` -> `1.25.1` |---### Release Notes<details><summary>go-gitea/gitea (go-gitea/gitea)</summary>### [`v1.25.1`](https://github.com/go-gitea/gitea/releases/tag/v1.25.1)[Compare Source](go-gitea/gitea@v1.25.0...v1.25.1)- BUGFIXES - Make ACME email optional ([#​35849](go-gitea/gitea#35849)) [#​35857](go-gitea/gitea#35857) - Add a doctor command to fix inconsistent run status ([#​35840](go-gitea/gitea#35840)) ([#​35845](go-gitea/gitea#35845)) - Remove wrong code ([#​35846](go-gitea/gitea#35846)) - Fix viewed files number is not right if not all files loaded ([#​35821](go-gitea/gitea#35821)) ([#​35844](go-gitea/gitea#35844)) - Fix incorrect pull request counter ([#​35819](go-gitea/gitea#35819)) ([#​35841](go-gitea/gitea#35841)) - Upgrade go mail to 0.7.2 and fix the bug ([#​35833](go-gitea/gitea#35833)) ([#​35837](go-gitea/gitea#35837)) - Revert gomail to v0.7.0 to fix sending mail failed ([#​35816](go-gitea/gitea#35816)) ([#​35824](go-gitea/gitea#35824)) - Fix clone mixed bug ([#​35810](go-gitea/gitea#35810)) ([#​35822](go-gitea/gitea#35822)) - Fix cli "Before" handling ([#​35797](go-gitea/gitea#35797)) ([#​35808](go-gitea/gitea#35808)) - Improve and fix markup code preview rendering ([#​35777](go-gitea/gitea#35777)) ([#​35787](go-gitea/gitea#35787)) - Fix actions rerun bug ([#​35783](go-gitea/gitea#35783)) ([#​35784](go-gitea/gitea#35784)) - Fix actions schedule update issue ([#​35767](go-gitea/gitea#35767)) ([#​35774](go-gitea/gitea#35774)) - Fix circular spin animation direction ([#​35785](go-gitea/gitea#35785)) ([#​35823](go-gitea/gitea#35823)) - Fix file extension on gogs.png ([#​35793](go-gitea/gitea#35793)) ([#​35799](go-gitea/gitea#35799)) - Add pnpm to Snapcraft ([#​35778](go-gitea/gitea#35778))Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xOC4xIiwidXBkYXRlZEluVmVyIjoiNDEuMTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsia2luZC9kZXBlbmRlbmN5Il19-->Reviewed-on:https://gitea.com/gitea/helm-gitea/pulls/981Reviewed-by: Markus Pesch <volker.raschek@noreply.gitea.com>Co-authored-by: Renovate Bot <renovate-bot@gitea.com>Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Closed
pimpale added a commit to hud-evals/gitea that referenced this pull requestDec 14, 2025
Tests verify that:1. Rerunning non-done workflows (StatusRunning) is rejected2. Rerunning completed workflows succeeds (positive case)3. Rerunning waiting workflows (due to concurrency) is rejectedRelated: PRgo-gitea#35783
pimpale added a commit to hud-evals/gitea that referenced this pull requestDec 14, 2025
Add validation check to prevent rerunning workflows/jobs that arenot in a done state (StatusSuccess/StatusFailure/StatusCancelled/StatusSkipped).Related: PRgo-gitea#35783
pimpale pushed a commit to hud-evals/gitea that referenced this pull requestDec 14, 2025
go-gitea#35783 fixes an actions rerun bug. Due to this bug, some runs may beincorrectly marked as `StatusWaiting` even though all the jobs are indone status. These runs cannot be run or cancelled. This PR adds a newdoctor command to fix the inconsistent run status.```gitea doctor check --run fix-actions-unfinished-run-status --fix```Thanks to@ChristopherHX for the test.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
backport/doneAll backports for this PR have been created backport/v1.25lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/goPull requests that update Go code type/bug
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Related issues:#35780,#35782
Rerunning a job or a run is only allowed when the job is done and the run is done.
Related PR:#34970
gitea/routers/web/repo/actions/view.go
Line 239 in98ff7d0
We don't need to check run status again in
rerunJobbecause the run status has been changed beforererunJob.In fact, the bug described in the above issues will not occur on the main branch. Because
getRunJobsis called before updating the run.gitea/routers/web/repo/actions/view.go
Lines 425 to 435 in98ff7d0
So the run status that
rerunJobchecks is the old status.