Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleanup ActionRun creation#35624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHXChristopherHX commentedOct 10, 2025•
edited
Loading

  • share more logic

Closes#35622

wxiaoguang, delvh, and Zettat123 reacted with thumbs up emoji
* share more logic
@ChristopherHXChristopherHX added type/bug type/refactoringExisting code has been cleaned up. There should be no new functionality. topic/gitea-actionsrelated to the actions of Gitea labelsOct 10, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelOct 10, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelOct 10, 2025
@ChristopherHXChristopherHX marked this pull request as ready for reviewOctober 11, 2025 10:51
@ChristopherHX
Copy link
ContributorAuthor

This shows how, worse the duplication is at the moment. Preparation for further refactoring.

Maybe

  • merge the new PrepareRun with InsertRun
  • change the name of PrepareRun

At least the surface of doing code path specific inconsistent changes decreases and more tests cover the shared code than the specific code ever did.

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsOct 11, 2025
ChristopherHXand others added3 commitsOctober 11, 2025 20:49
Co-authored-by: delvh <dev.lh@web.de>Signed-off-by: ChristopherHX <christopher.homberger@web.de>
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsOct 11, 2025
@github-actionsgithub-actionsbot added the modifies/apiThis PR adds API routes or modifies them labelOct 12, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commentedOct 12, 2025•
edited
Loading

Made some new changes, now we require callers to pass "run" when callingCreateCommitStatusForRunJobs, then it isCreateCommitStatusForRunJobs's responsibility to decide whether to create the status (for example: no status for cron/scheduled jobs). And we only need to retrieve event name and commit id once for a run.

ChristopherHX reacted with thumbs up emoji

@ChristopherHX
Copy link
ContributorAuthor

Thank you for your additional refactoring. I had something similar in my mind for optimizing the code later.

wxiaoguang reacted with thumbs up emojiwxiaoguang reacted with heart emoji

@wxiaoguangwxiaoguangenabled auto-merge (squash)October 12, 2025 12:22
@wxiaoguangwxiaoguang merged commit2401812 intogo-gitea:mainOct 12, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.26.0 milestoneOct 12, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestOct 13, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Update JS deps, misc tweaks (go-gitea#35643)  Bump actions/checkout to v5 (go-gitea#35644)  nix flake update (go-gitea#35639)  Cleanup ActionRun creation (go-gitea#35624)  bump archives&rar dep (go-gitea#35637)  Fix merge panic (go-gitea#35606)  Bump happy-dom from 19.0.2 to 20.0.0 (go-gitea#35625)  Refactor ActionRunJob parsing into a reusable function (go-gitea#35623)  Fix code tag style problem and LFS view bug (go-gitea#35628)  Support Actions `concurrency` syntax (go-gitea#32751)  The status icon of the Action step is consistent with GitHub (go-gitea#35618)  Mock external service in hcaptcha TestCaptcha (go-gitea#35604)  Fix inputing review comment will remove reviewer (go-gitea#35591)  [skip ci] Updated translations via Crowdin  Fix diffpatch API endpoint (go-gitea#35610)  Print PR-Title into tooltip for actions (go-gitea#35579)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wxiaoguangwxiaoguangwxiaoguang approved these changes

@delvhdelvhdelvh approved these changes

+1 more reviewer

@Zettat123Zettat123Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/apiThis PR adds API routes or modifies themmodifies/goPull requests that update Go codetopic/gitea-actionsrelated to the actions of Giteatype/bugtype/refactoringExisting code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Inconsistent context availability in run-name

5 participants

@ChristopherHX@wxiaoguang@Zettat123@delvh@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp