Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Add proper error message if session provider can not be created#35520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
6543 merged 10 commits intogo-gitea:mainfrom6543-forks:propper-error-for-sessioner-creation-failSep 28, 2025
Merged
Add proper error message if session provider can not be created#35520
6543 merged 10 commits intogo-gitea:mainfrom6543-forks:propper-error-for-sessioner-creation-failSep 28, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
delvh approved these changesSep 23, 2025
Uh oh!
There was an error while loading.Please reload this page.
MemberAuthor
6543 commentedSep 26, 2025
PS: looks like we dont use Exist and Count in our codebase at all (beside to define providers to match that interface ...) this should be an relict from the time we migrated away from macaron to chi ... can we move the code into our codebase and refactore e.g. drop unused stuff etc ? -> should be another pull and i dont have time to do that atm |
6543 commentedSep 27, 2025
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: 6543 <6543@obermui.de>
making edits by mobile is hard ...
MemberAuthor
6543 commentedSep 27, 2025
making changes via mobil via web is hard ... |
MemberAuthor
6543 commentedSep 27, 2025
@lunny should be ready now 😅 |
lunny approved these changesSep 28, 2025
fbe80e6 intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
rossigee pushed a commit to rossigee/gitea that referenced this pull requestOct 2, 2025
…itea#35520)the middleware that creates the session provider just panics if oncreation the config is wrong.this is not catched and so you just get an cryptic stacktrace with nopoint where to look at (as user).## Before```2025/09/16 03:56:37 ...xer/stats/indexer.go:87:populateRepoIndexer() [I] Done (re)populating the repo stats indexer with existing repositories2025/09/16 03:56:37 modules/ssh/ssh.go:387:Listen() [I] Adding SSH host key: /var/lib/gitea/data/ssh/gitea.rsa2025/09/16 03:56:37 modules/ssh/init.go:26:Init() [I] SSH server started on :1234. Cipher list ([chacha20-poly1305@openssh.com aes128-ctr aes192-ctr aes256-ctr aes128-gcm@openssh.com aes256-gcm@openssh.com]), key exchange algorithms ([curve25519-sha256 ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 diffie-hellman-group14-sha256 diffie-hellman-group14-sha1]), MACs ([hmac-sha2-256-etm@openssh.com hmac-sha2-256 hmac-sha1])2025/09/16 03:56:37 ...s/graceful/server.go:50:NewServer() [I] Starting new SSH server: tcp::1234 on PID: 833372025/09/16 03:56:38 cmd/web.go:231:func1() [F] PANIC: dial tcp 127.0.0.1:6379: connect: connection refusedgitea.com/go-chi/session@v0.0.0-20240316035857-16768d98ec96/session.go:239 (0x1cdb908)code.gitea.io/gitea/routers/common/middleware.go:108 (0x2547f5a)code.gitea.io/gitea/routers/web/web.go:270 (0x278b8e9)code.gitea.io/gitea/routers/init.go:185 (0x2850d89)code.gitea.io/gitea/cmd/web.go:211 (0x295c5ad)code.gitea.io/gitea/cmd/web.go:262 (0x295cacb)code.gitea.io/gitea/cmd/main.go:111 (0x2953422)github.com/urfave/cli/v2@v2.27.2/command.go:276 (0x1cc3dfd)github.com/urfave/cli/v2@v2.27.2/command.go:269 (0x1cc4084)github.com/urfave/cli/v2@v2.27.2/app.go:333 (0x1cc086a)github.com/urfave/cli/v2@v2.27.2/app.go:307 (0x2953f18)code.gitea.io/gitea/cmd/main.go:172 (0x2953efc)code.gitea.io/gitea/main.go:46 (0x2998498)runtime/proc.go:283 (0x4471ca)runtime/asm_amd64.s:1700 (0x484a20)```## After```2025/09/22 22:52:35 .../templates/htmlrenderer.go:118:initHTMLRenderer() [D] Creating static HTML Renderer2025/09/22 22:52:35 routers/web/web.go:273:Routes() [F] common.Sessioner failed: failed to create session middleware: dial tcp 127.0.0.1:6379: connect: connection refused```---------Signed-off-by: 6543 <6543@obermui.de>
rossigee pushed a commit to rossigee/gitea that referenced this pull requestOct 4, 2025
…itea#35520)the middleware that creates the session provider just panics if oncreation the config is wrong.this is not catched and so you just get an cryptic stacktrace with nopoint where to look at (as user).## Before```2025/09/16 03:56:37 ...xer/stats/indexer.go:87:populateRepoIndexer() [I] Done (re)populating the repo stats indexer with existing repositories2025/09/16 03:56:37 modules/ssh/ssh.go:387:Listen() [I] Adding SSH host key: /var/lib/gitea/data/ssh/gitea.rsa2025/09/16 03:56:37 modules/ssh/init.go:26:Init() [I] SSH server started on :1234. Cipher list ([chacha20-poly1305@openssh.com aes128-ctr aes192-ctr aes256-ctr aes128-gcm@openssh.com aes256-gcm@openssh.com]), key exchange algorithms ([curve25519-sha256 ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 diffie-hellman-group14-sha256 diffie-hellman-group14-sha1]), MACs ([hmac-sha2-256-etm@openssh.com hmac-sha2-256 hmac-sha1])2025/09/16 03:56:37 ...s/graceful/server.go:50:NewServer() [I] Starting new SSH server: tcp::1234 on PID: 833372025/09/16 03:56:38 cmd/web.go:231:func1() [F] PANIC: dial tcp 127.0.0.1:6379: connect: connection refusedgitea.com/go-chi/session@v0.0.0-20240316035857-16768d98ec96/session.go:239 (0x1cdb908)code.gitea.io/gitea/routers/common/middleware.go:108 (0x2547f5a)code.gitea.io/gitea/routers/web/web.go:270 (0x278b8e9)code.gitea.io/gitea/routers/init.go:185 (0x2850d89)code.gitea.io/gitea/cmd/web.go:211 (0x295c5ad)code.gitea.io/gitea/cmd/web.go:262 (0x295cacb)code.gitea.io/gitea/cmd/main.go:111 (0x2953422)github.com/urfave/cli/v2@v2.27.2/command.go:276 (0x1cc3dfd)github.com/urfave/cli/v2@v2.27.2/command.go:269 (0x1cc4084)github.com/urfave/cli/v2@v2.27.2/app.go:333 (0x1cc086a)github.com/urfave/cli/v2@v2.27.2/app.go:307 (0x2953f18)code.gitea.io/gitea/cmd/main.go:172 (0x2953efc)code.gitea.io/gitea/main.go:46 (0x2998498)runtime/proc.go:283 (0x4471ca)runtime/asm_amd64.s:1700 (0x484a20)```## After```2025/09/22 22:52:35 .../templates/htmlrenderer.go:118:initHTMLRenderer() [D] Creating static HTML Renderer2025/09/22 22:52:35 routers/web/web.go:273:Routes() [F] common.Sessioner failed: failed to create session middleware: dial tcp 127.0.0.1:6379: connect: connection refused```---------Signed-off-by: 6543 <6543@obermui.de>
zjjhot added a commit to zjjhot/gitea that referenced this pull requestOct 5, 2025
* giteaofficial/main: fix: auto-expand and auto-scroll for actions logs (go-gitea#35570) (go-gitea#35583) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix creating pull request failure when the target branch name is the same as some tag (go-gitea#35552) Use bundled version of spectral (go-gitea#35573) Add rebase push display wrong comments bug (go-gitea#35560) Address some CodeQL security concerns (go-gitea#35572) fix(webhook): prevent tag events from bypassing branch filters targetsgo-gitea#35449 (go-gitea#35567) Added button to copy file name in PR files (go-gitea#35509) Update JS and PY deps (go-gitea#35565) Enable a few more tsconfig options (go-gitea#35553) Bump github.com/wneessen/go-mail from 0.6.2 to 0.7.1 (go-gitea#35557) add more routes to the "expensive" list (go-gitea#35547) Drop json-iterator dependency (go-gitea#35544) Add proper error message if session provider can not be created (go-gitea#35520) use experimental go json v2 library (go-gitea#35392) Use global lock instead of status pool for cron lock (go-gitea#35507) Move some functions to gitrepo package (go-gitea#35503) Move GetDiverging functions to gitrepo (go-gitea#35524) [skip ci] Updated translations via Crowdin
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependenciesmodifies/goPull requests that update Go code type/enhancementAn improvement of existing functionality
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
the middleware that creates the session provider just panics if on creation the config is wrong.
this is not catched and so you just get an cryptic stacktrace with no point where to look at (as user).
Before
After