Movatterモバイル変換

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labels

lunny added the type/bug label

wxiaoguang reviewed

gitea/services/context/upload/upload.go

routers/api/v1/repo/release_attachment.go Outdated


		// Create a new attachment and save the file
		attach,err:=attachment_service.UploadAttachment(ctx,content,setting.Repository.Release.AllowedTypes,size,&repo_model.Attachment{
		attach,err:=attachment_service.UploadAttachment(ctx,content,setting.Repository.Release.AllowedTypes,setting.Attachment.MaxSize<<20,size,&repo_model.Attachment{

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There are at least 2 "attachment max size" config options.

If you always usesetting.Attachment.MaxSize, at least one is wrong

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why? looks they are all same in curent design. hasn't found anything likesetting.Repository.Release.MaxSize.

ref:

Lines 90 to 114 in0b706b0

	// AddUploadContext renders template values for dropzone
	funcAddUploadContext(ctx*context.Context,uploadTypestring) {
	switchuploadType {
	case"release":
	ctx.Data["UploadUrl"]=ctx.Repo.RepoLink+"/releases/attachments"
	ctx.Data["UploadRemoveUrl"]=ctx.Repo.RepoLink+"/releases/attachments/remove"
	ctx.Data["UploadLinkUrl"]=ctx.Repo.RepoLink+"/releases/attachments"
	ctx.Data["UploadAccepts"]=strings.ReplaceAll(setting.Repository.Release.AllowedTypes,"\|",",")
	ctx.Data["UploadMaxFiles"]=setting.Attachment.MaxFiles
	ctx.Data["UploadMaxSize"]=setting.Attachment.MaxSize
	case"comment":
	ctx.Data["UploadUrl"]=ctx.Repo.RepoLink+"/issues/attachments"
	ctx.Data["UploadRemoveUrl"]=ctx.Repo.RepoLink+"/issues/attachments/remove"
	iflen(ctx.PathParam("index"))>0 {
	ctx.Data["UploadLinkUrl"]=ctx.Repo.RepoLink+"/issues/"+url.PathEscape(ctx.PathParam("index"))+"/attachments"
	}else {
	ctx.Data["UploadLinkUrl"]=ctx.Repo.RepoLink+"/issues/attachments"
	}
	ctx.Data["UploadAccepts"]=strings.ReplaceAll(setting.Attachment.AllowedTypes,"\|",",")
	ctx.Data["UploadMaxFiles"]=setting.Attachment.MaxFiles
	ctx.Data["UploadMaxSize"]=setting.Attachment.MaxSize
	default:
	setting.PanicInDevOrTesting("Invalid upload type: %s",uploadType)
	}
	}

Copy link

Contributor

wxiaoguangSep 24, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

~~Oh you are right, release upload shares the same attachment max size with comment attachment, but doesn't share some other settings .....~~

~~It seems to be another (unrelated) legacy problem.~~

(Update: see next)

Copy link

Contributor

wxiaoguangOct 11, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Update: the problem I mentionedThere are at least 2 "attachment max size" config options. is still there. See my latest comment forUploadFileToServer, there is no limit check either.

fix attachment file size limit in server backend #35519 (comment)

wxiaoguang reviewed

services/attachment/attachment.go OutdatedShow resolvedHide resolved

wxiaoguang reviewed

services/attachment/attachment.go OutdatedShow resolvedHide resolved

a1012112796and others added4 commits

September 24, 2025 22:19

Merge remote-tracking branch 'origin/main' into zzc/dev/attach_size_l…

d11f7c8

…imit

fix nits

e19a4b1

user modern golang error system

5f200ee

Merge branch 'main' into zzc/dev/attach_size_limit

f8c7971

Copy link

Member

6543 commentedOct 7, 2025

@a1012112796 ->a1012112796#13

6543 added3 commits

October 7, 2025 10:27

Update services/attachment/reader.go

7316593

Update services/attachment/reader.go

9e16482

Update services/attachment/reader.go

9c1e0b5

GiteaBot added the lgtm/blockedA maintainer has reservations with the PR and thus it cannot be merged label

Oct 11, 2025

Copy link

Contributor

wxiaoguang commentedOct 11, 2025

errors.Is dont work now (just revert commit looked at jet)

What do you mean by "errors.Is dont work now"?

Copy link

Member

6543 commentedOct 11, 2025

i will have time tomorrow, review via mobule is horrible

Copy link

Contributor

wxiaoguang commentedOct 11, 2025

creating custom errors is fine and all but we should workwith golangs error handling system witch means that we should cover unwrap and is interface

Isn't it what I have done? I don't see any problem.

lunny approved these changes

Oct 11, 2025

Copy link

Contributor

wxiaoguang commentedOct 12, 2025

errors.Is dont work now
What do you mean by "errors.Is dont work now"?
creating custom errors is fine and all but we should workwith golangs error handling system witch means that we
should cover unwrap and is interface
Isn't it what I have done? I don't see any problem.
i will have time tomorrow, review via mobule is horrible

@6543 so where is the problem? I think you misunderstood the "golangs error handling system". If no problem, dismiss the change request.

Copy link

Contributor

wxiaoguang commentedOct 15, 2025

errors.Is dont work now
What do you mean by "errors.Is dont work now"?
creating custom errors is fine and all but we should workwith golangs error handling system witch means that we
should cover unwrap and is interface
Isn't it what I have done? I don't see any problem.
i will have time tomorrow, review via mobule is horrible
@6543 so where is the problem? I think you misunderstood the "golangs error handling system". If no problem, dismiss the change request.

@6543 so where is the problem? I think you misunderstood the "golangs error handling system". If no problem, dismiss the change request.

Copy link

Contributor

wxiaoguang commentedOct 16, 2025

errors.Is dont work now
What do you mean by "errors.Is dont work now"?
creating custom errors is fine and all but we should workwith golangs error handling system witch means that we
should cover unwrap and is interface
Isn't it what I have done? I don't see any problem.
i will have time tomorrow, review via mobule is horrible
@6543 so where is the problem? I think you misunderstood the "golangs error handling system". If no problem, dismiss the change request.
@6543 so where is the problem? I think you misunderstood the "golangs error handling system". If no problem, dismiss the change request.

@6543 If no problem, dismiss the change request.

lunny dismissed6543’sstale review

October 16, 2025 18:14

Dismissed as no response.

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/blockedA maintainer has reservations with the PR and thus it cannot be merged labels

Oct 16, 2025

Merge branch 'main' into zzc/dev/attach_size_limit

a1c39e8

wxiaoguang approved these changes

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labels

wxiaoguangenabled auto-merge (squash)

October 21, 2025 14:00

wxiaoguang added3 commits

October 21, 2025 22:25

improve tests

e5a75a6

fix buffer usage

8f9060b

fix lint

32d033b

wxiaoguang merged commita4e23b8 intogo-gitea:main

26 checks passed

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request

fix attachment file size limit in server backend (go-gitea#35519)

f9dfd00

fixgo-gitea#35512---------Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

GiteaBot mentioned this pull request

fix attachment file size limit in server backend (#35519)#35720

Merged

GiteaBot added the backport/doneAll backports for this PR have been created label

lunny pushed a commit that referenced this pull request