Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix push commits comments when changing the pull request target branch (#35386)#35443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@lunny
Copy link
Member

Backport#35386

When changing the pull request target branch, the pushed commits comments will not be changed resulted the number are inconsistent between commits tab number and the pushed commits comments number.

This PR will remove all the previous pushed commits comments and calculate new comments when changing the target branch.

Before:

image

After:
image

go-gitea#35386)When changing the pull request target branch, the pushed commitscomments will not be changed resulted the number are inconsistentbetween commits tab number and the pushed commits comments number.This PR will remove all the previous pushed commits comments andcalculate new comments when changing the target branch.Before:<img width="928" height="585" alt="image"src="https://github.com/user-attachments/assets/35e4d31f-31a1-4d14-83b0-1786721ab0d9"/>After:<img width="816" height="623" alt="image"src="https://github.com/user-attachments/assets/24b6dafe-9238-4e7e-833d-68472457afab"/>
@GiteaBotGiteaBot added this to the1.24.6 milestoneSep 9, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelSep 9, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelSep 9, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsSep 10, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsSep 10, 2025
@silverwindsilverwind merged commit78fbcf3 intogo-gitea:release/v1.24Sep 10, 2025
26 checks passed
@lunnylunny deleted the lunny/fix_changetarget_commit_list2 branchSeptember 10, 2025 01:56
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsDec 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@silverwindsilverwindsilverwind approved these changes

+1 more reviewer

@hiifonghiifonghiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go code

Projects

None yet

Milestone

1.24.6

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny@silverwind@hiifong@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp