NotificationsYou must be signed in to change notification settings
Fork6.3k
Star52.6k

fix: remove duplicate IDs#35210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

6543 merged 8 commits intogo-gitea:mainfromkerwin612:feature/multi-line-selection-url

Aug 18, 2025

Merged

fix: remove duplicate IDs#35210

6543 merged 8 commits intogo-gitea:mainfromkerwin612:feature/multi-line-selection-url

Aug 18, 2025

Conversation

Copy link

Member

kerwin612 commentedAug 4, 2025•
edited
Loading

No description provided.

feat: support multi-line selection with URL parameters

32b4725

GiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. label

Aug 4, 2025

github-actionsbot added modifies/templates

This PR modifies the template files

modifies/frontend labels

Aug 4, 2025

silverwind reviewed

Aug 4, 2025

View reviewed changes

web_src/js/features/repo-code.ts OutdatedShow resolvedHide resolved

silverwind reviewed

Aug 4, 2025

View reviewed changes

web_src/js/features/repo-code.ts OutdatedShow resolvedHide resolved

kerwin612and others added2 commits

August 4, 2025 21:22

Update web_src/js/features/repo-code.ts

d7ccf38

Co-authored-by: silverwind <me@silverwind.io>Signed-off-by: Kerwin Bryant <kerwin612@qq.com>

Update web_src/js/features/repo-code.ts

c63f1d2

Co-authored-by: silverwind <me@silverwind.io>Signed-off-by: Kerwin Bryant <kerwin612@qq.com>

appleboy approved these changes

Aug 4, 2025

View reviewed changes

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labels

Aug 4, 2025

lunny approved these changes

Aug 5, 2025

View reviewed changes

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labels

Aug 5, 2025

lunny added this to the1.25.0 milestone

Aug 5, 2025

wxiaoguang previously requested changes

Aug 5, 2025

View reviewed changes

Copy link

Contributor

wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think other pages are broken.

GiteaBot added lgtm/blockedA maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. labels

Aug 5, 2025

wxiaoguang reviewed

Aug 5, 2025

View reviewed changes

web_src/js/features/repo-code.ts OutdatedShow resolvedHide resolved

clean code

886f546

kerwin612 force-pushed thefeature/multi-line-selection-url branch from291c27c to886f546Compare

August 9, 2025 09:35

kerwin612 requested a review fromwxiaoguang

August 9, 2025 09:54

Copy link

Contributor

wxiaoguang commentedAug 9, 2025

Have you fixed the problems?

ps: I don't have time recently, feel free to ask other maintainers to review and dismiss my "change request" if the bugs have been fixed.

wxiaoguang removed their request for review

August 9, 2025 13:16

wxiaoguang reviewed

Aug 9, 2025

View reviewed changes

web_src/js/features/repo-code.ts OutdatedShow resolvedHide resolved

kerwin612 added2 commits

August 11, 2025 10:00

Merge branch 'main' into feature/multi-line-selection-url

4916e7f

clean code

e5774b5

kerwin612 requested a review froma team

August 11, 2025 02:15

wxiaoguang reviewed

Aug 11, 2025

View reviewed changes

web_src/js/features/repo-code.ts OutdatedShow resolvedHide resolved

Update repo-code.ts

9ca5c42

github-actionsbot removed the modifies/frontend label

Aug 11, 2025

kerwin612 changed the title~~feat: support multi-line selection with URL parameters~~fix: remove duplicate IDs

Aug 11, 2025

lunny requested a review fromwxiaoguang

August 18, 2025 03:19

Copy link

Contributor

wxiaoguang commentedAug 18, 2025

No need to ask for my review.

Actually I don't understand the details of "feat: support multi-line selection with URL parameters" and "fix: remove duplicate IDs", no idea about the changed code (most changes have been reverted and only one line changes now), so no idea what it is going to fix.

ps: I don't have time recently, feel free to ask other maintainers to review and dismiss my "change request" if the bugs have been fixed.

If you know what it is for and have tested it, and it works as expectation, feel free to remove my "change request".

wxiaoguang removed their request for review

August 18, 2025 05:25

lunny dismissedwxiaoguang’sstale review

August 18, 2025 16:26

The PR's purpose changed. Now it will remove the duplicated div id to prevent possible problem.

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blockedA maintainer has reservations with the PR and thus it cannot be merged labels

Aug 18, 2025

lunny added type/bug backport/v1.24

This PR should be backported to Gitea 1.24

reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labels

Aug 18, 2025

Merge branch 'main' into feature/multi-line-selection-url

d601ec5

6543 approved these changes

Aug 18, 2025

View reviewed changes

6543 merged commit4ea8f33 intogo-gitea:main

Aug 18, 2025

26 checks passed

GiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. label

Aug 18, 2025

Copy link

Collaborator

GiteaBot commentedAug 18, 2025

I was unable to create a backport for 1.24.@kerwin612, please send one manually. 🍵

go run ./contrib/backport 35210...  // fix git conflicts if anygo run ./contrib/backport --continue

GiteaBot added the backport/manualNo power to the bots! Create your backport yourself! label

Aug 18, 2025

kerwin612 deleted the feature/multi-line-selection-url branch

August 19, 2025 07:05

zjjhot added a commit to zjjhot/gitea that referenced this pull request

Aug 19, 2025

Merge remote-tracking branch 'giteaofficial/main'

b84a143

* giteaofficial/main:  Refactor smal code snippeds in models/issues/pull.go  (go-gitea#35301)  fix: remove duplicate IDs (go-gitea#35210)  Add start time on perf trace because it seems some steps haven't been recorded. (go-gitea#35282)  nix dev shell add zip (go-gitea#35300)  [skip ci] Updated translations via Crowdin  Fix LFS range size header response (go-gitea#35277)  Skip "parentsigned" check when the repo is empty (go-gitea#35292)  [skip ci] Updated translations via Crowdin  Fix GitHub release assets URL validation (go-gitea#35287)  nix flake use go1.25 (go-gitea#35288)  go1.25.0 (go-gitea#35262)  fix nix dev shell on darwin (go-gitea#35278)  Fix token lifetime,closesgo-gitea#35230 (go-gitea#35271)  OneDev migration: fix broken migration caused by various REST API changes in OneDev 7.8.0 and later (go-gitea#35216)  [skip ci] Updated translations via Crowdin  Fix font-size in inline code comment preview (go-gitea#35209)  Fix a bug where lfs gc never worked. (go-gitea#35198)