Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Change some columns from text to longtext and fix column wrong type caused by xorm#35141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
delvh approved these changesJul 21, 2025
Member
hiifong commentedJul 22, 2025
No sqlite support? |
lafriks approved these changesJul 22, 2025
Contributor
wxiaoguang commentedJul 22, 2025
And, should it also include a fix for "uploading rpm with large metadata fails with mysql/mariadb database#35042" ? |
MemberAuthor
lunny commentedJul 23, 2025
SQLite doesn't support to change column type and it's unnecessary to change it for SQLite because TEXT is the same as LONGTEXT in SQLITE. |
hiifong approved these changesJul 23, 2025
54fe47f intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 28, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix migrate input box bug (go-gitea#35166) [skip ci] Updated translations via Crowdin Only hide dropzone when no files have been uploaded (go-gitea#35156) Change some columns from text to longtext and fix column wrong type caused by xorm (go-gitea#35141) [skip ci] Updated translations via Crowdin Add `owner` and `parent` fields clarification to docs (go-gitea#35023) Improve language in en-US locale strings (go-gitea#35124)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependenciesmodifies/goPull requests that update Go code modifies/migrationstype/bug
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR upgrade xorm to v1.3.10 which fixed a bug when both
longtext jsontags in the struct field. Thelongtextwill be ignored andjsonwill be considered astext.A migration has been introduced to modify the column directly to longtext. And another two columns should also be migrated from text to longtext.
All these changes only affect mysql database because for other databases Gitea supported, text is the same as longtext.
Fix#27244
Fix#34764
Fix#35042