Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Fix submodule nil check#35096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Fix submodule nil check#35096
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
delvh approved these changesJul 16, 2025
silverwind approved these changesJul 16, 2025
fc4cb07 intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull requestJul 16, 2025
wxiaoguang added a commit that referenced this pull requestJul 16, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 18, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Increase gap on latest commit (go-gitea#35104) Fix job status aggregation logic (go-gitea#35000) Fix some missed GitHeadRefName when renaming (go-gitea#35102) Fix error logs and improve some comments/messages (go-gitea#35105) Support Basic Authentication for archive downloads (go-gitea#35087) Run `uv run` with `--frozen` (go-gitea#35097) Improve package API log handling (go-gitea#35100) Rename pull request GetGitRefName to GetGitHeadRefName (go-gitea#35093) Fix review comment/dimiss comment x reference can be refereced back (go-gitea#35094) Fix submodule nil check (go-gitea#35096) Redirect to a presigned URL of HEAD for HEAD requests (go-gitea#35088)
wxiaoguang added a commit that referenced this pull requestJul 18, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull requestJul 18, 2025
Follow upgo-gitea#35096,fixgo-gitea#35095,fixgo-gitea#35115 and add more testsThe old code used some fragile behaviors which depend on the "nil"receiver. This PR should be a complete fix for more edge cases.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
backport/doneAll backports for this PR have been created backport/v1.24This PR should be backported to Gitea 1.24 lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/goPull requests that update Go code type/bug
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#35095