Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Redirect to a presigned URL of HEAD for HEAD requests#35088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
wxiaoguang approved these changesJul 16, 2025
hiifong approved these changesJul 16, 2025
ContributorAuthor
risu729 commentedJul 16, 2025
Thank you for the prompt review and for adding the test! |
Contributor
wxiaoguang commentedJul 16, 2025
Thank you very much for the improvement, let's merge and try 😄 |
e1e4815 intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 18, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Increase gap on latest commit (go-gitea#35104) Fix job status aggregation logic (go-gitea#35000) Fix some missed GitHeadRefName when renaming (go-gitea#35102) Fix error logs and improve some comments/messages (go-gitea#35105) Support Basic Authentication for archive downloads (go-gitea#35087) Run `uv run` with `--frozen` (go-gitea#35097) Improve package API log handling (go-gitea#35100) Rename pull request GetGitRefName to GetGitHeadRefName (go-gitea#35093) Fix review comment/dimiss comment x reference can be refereced back (go-gitea#35094) Fix submodule nil check (go-gitea#35096) Redirect to a presigned URL of HEAD for HEAD requests (go-gitea#35088)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code type/bug
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#35086.
Sorry, I was not sure where to add the new tests.
The original PR#11387 does not include the test for presigned URLs.
Also, I'm new to Go, so I apologise if the design of the function parameters is bad.