NotificationsYou must be signed in to change notification settings
Fork6.3k
Star52.6k

Support Basic Authentication for archive downloads#35087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lunny merged 2 commits intogo-gitea:mainfrompvgoran:archives-basic-authentication

Jul 16, 2025

Merged

Support Basic Authentication for archive downloads#35087

lunny merged 2 commits intogo-gitea:mainfrompvgoran:archives-basic-authentication

Jul 16, 2025

Conversation

Copy link

Contributor

pvgoran commentedJul 15, 2025

Resolves#35083

Support Basic Authentication for archive downloads

4fa1909

Resolvesgo-gitea#35083

GiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. label

Jul 15, 2025

github-actionsbot added the modifies/goPull requests that update Go code label

Jul 15, 2025

Copy link

ContributorAuthor

It just occurred to be that the PR/commit title should say "repository archive" rather than just "archive". Not changing it now sincehttps://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#maintaining-open-prs possibly implies that I shouldn't. (Unless someone says it's OK to do.)

Copy link

Member

lunny commentedJul 15, 2025

It's better to have a test for that.

Copy link

ContributorAuthor

pvgoran commentedJul 15, 2025

It's better to have a test for that.

Where could a test be added, what would it test, and how would I run such a test? (I don't know a thing about testing facilities of Gitea - or of Go in general, for that matter.)

When I look at#33371 for inspiration, I only find something that looks like a test for theisFeedRequest() function. Here, do I need to test just theisArchivePath() function in a similar way, too?

wxiaoguang approved these changes

Jul 16, 2025

View reviewed changes

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labels

Jul 16, 2025

wxiaoguang added this to the1.25.0 milestone

Jul 16, 2025

wxiaoguang added the type/enhancementAn improvement of existing functionality label

Jul 16, 2025

hiifong approved these changes

Jul 16, 2025

View reviewed changes

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labels

Jul 16, 2025

lunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. label

Jul 16, 2025

Merge branch 'main' into archives-basic-authentication

cc18ade

lunny merged commit891a827 intogo-gitea:main

Jul 16, 2025

26 checks passed

GiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. label

Jul 16, 2025

zjjhot added a commit to zjjhot/gitea that referenced this pull request

Jul 18, 2025

Merge remote-tracking branch 'giteaofficial/main'

3ddb542

* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Increase gap on latest commit (go-gitea#35104)  Fix job status aggregation logic (go-gitea#35000)  Fix some missed GitHeadRefName when renaming (go-gitea#35102)  Fix error logs and improve some comments/messages (go-gitea#35105)  Support Basic Authentication for archive downloads (go-gitea#35087)  Run `uv run` with `--frozen` (go-gitea#35097)  Improve package API log handling (go-gitea#35100)  Rename pull request GetGitRefName to GetGitHeadRefName (go-gitea#35093)  Fix review comment/dimiss comment x reference can be refereced back (go-gitea#35094)  Fix submodule nil check (go-gitea#35096)  Redirect to a presigned URL of HEAD for HEAD requests (go-gitea#35088)