Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix ListWorkflowRuns OpenAPI response model.#35026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ScionOfDesign
Copy link
Contributor

Change the OpenAPI response ofListWorkflowRuns toWorkflowRunsList like it is supposed to be.

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 10, 2025
@github-actionsgithub-actionsbot added modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code labelsJul 10, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 10, 2025
@ScionOfDesign
Copy link
ContributorAuthor

Hold off for a bit, I just encountered another error when actually trying to deserialize this endpoint toWorkflowRunsList.

@wxiaoguangwxiaoguang marked this pull request as draftJuly 10, 2025 02:13
@ScionOfDesign
Copy link
ContributorAuthor

It's odd, in the response bothlicenses andrepo_transfer are being returned as null, but they arerequired in the OpenAPI spec:

"has_wiki":true,"has_pull_requests":true,"has_projects":true,"projects_mode":"all","has_releases":true,"has_packages":true,"has_actions":true,"ignore_whitespace_conflicts":false,"allow_merge_commits":true,"allow_rebase":true,"allow_rebase_explicit":true,"allow_squash_merge":true,"allow_fast_forward_only_merge":true,"allow_rebase_update":true,"allow_manual_merge":false,"autodetect_manual_merge":false,"default_delete_branch_after_merge":false,"default_merge_style":"merge","default_allow_maintainer_edit":false,"avatar_url":"","internal":false,"mirror_interval":"","object_format_name":"sha1","mirror_updated":"0001-01-01T00:00:00Z","repo_transfer":null,"topics": [],"licenses":null

@ScionOfDesign
Copy link
ContributorAuthor

Fixed the model to omit null (but not nullable) values and initialize the Licenses array in the response even if they are empty.

@ScionOfDesignScionOfDesign marked this pull request as ready for reviewJuly 10, 2025 04:26
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 10, 2025
@ScionOfDesign
Copy link
ContributorAuthor

Forgot that the original didn't have the pre-allocation. Your suggestion should be ideal.

@wxiaoguang
Copy link
Contributor

wxiaoguang commentedJul 10, 2025
edited
Loading

Forgot that the original didn't have the pre-allocation. Your suggestion should be ideal.

For performance-critical code, thatif and pre-allocation does help.

While here I think we can keepStringList as simple as before. TBH I think in this case there should be no noticeable difference, while simple code reads better.


(I just meant that in the convert function, we can't depend on the StringList's behavior)

ScionOfDesign reacted with thumbs up emoji

@wxiaoguangwxiaoguangenabled auto-merge (squash)July 10, 2025 05:31
@wxiaoguangwxiaoguang added backport/doneAll backports for this PR have been created backport/manualNo power to the bots! Create your backport yourself! backport/v1.24This PR should be backported to Gitea 1.24 labelsJul 10, 2025
@wxiaoguangwxiaoguang removed backport/doneAll backports for this PR have been created backport/manualNo power to the bots! Create your backport yourself! backport/v1.24This PR should be backported to Gitea 1.24 labelsJul 10, 2025
@wxiaoguangwxiaoguang merged commitaf0196c intogo-gitea:mainJul 10, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.25.0 milestoneJul 10, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 10, 2025
* giteaofficial/main:  Fix ListWorkflowRuns OpenAPI response model. (go-gitea#35026)  Partially refresh notifications list (go-gitea#35010)
@ScionOfDesignScionOfDesign deleted the fix-workflow-runs-openapi branchJuly 10, 2025 18:48
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@wxiaoguangwxiaoguangwxiaoguang approved these changes

@lunnylunnylunny approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/apiThis PR adds API routes or modifies themmodifies/goPull requests that update Go code

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ScionOfDesign@wxiaoguang@lunny@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp