Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Fix ListWorkflowRuns OpenAPI response model.#35026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix ListWorkflowRuns OpenAPI response model.#35026
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…t` like it is supposed to be.
ScionOfDesign commentedJul 10, 2025
Hold off for a bit, I just encountered another error when actually trying to deserialize this endpoint to |
ScionOfDesign commentedJul 10, 2025
It's odd, in the response both "has_wiki":true,"has_pull_requests":true,"has_projects":true,"projects_mode":"all","has_releases":true,"has_packages":true,"has_actions":true,"ignore_whitespace_conflicts":false,"allow_merge_commits":true,"allow_rebase":true,"allow_rebase_explicit":true,"allow_squash_merge":true,"allow_fast_forward_only_merge":true,"allow_rebase_update":true,"allow_manual_merge":false,"autodetect_manual_merge":false,"default_delete_branch_after_merge":false,"default_merge_style":"merge","default_allow_maintainer_edit":false,"avatar_url":"","internal":false,"mirror_interval":"","object_format_name":"sha1","mirror_updated":"0001-01-01T00:00:00Z","repo_transfer":null,"topics": [],"licenses":null |
ScionOfDesign commentedJul 10, 2025
Fixed the model to omit null (but not nullable) values and initialize the Licenses array in the response even if they are empty. |
Uh oh!
There was an error while loading.Please reload this page.
ScionOfDesign commentedJul 10, 2025
Forgot that the original didn't have the pre-allocation. Your suggestion should be ideal. |
wxiaoguang commentedJul 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
For performance-critical code, that While here I think we can keep (I just meant that in the convert function, we can't depend on the StringList's behavior) |
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
af0196c intogo-gitea:mainUh oh!
There was an error while loading.Please reload this page.
* giteaofficial/main: Fix ListWorkflowRuns OpenAPI response model. (go-gitea#35026) Partially refresh notifications list (go-gitea#35010)
Change the OpenAPI response of
ListWorkflowRunstoWorkflowRunsListlike it is supposed to be.