Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Alignissue-title-buttons withlist-header#35018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
silverwind merged 8 commits intogo-gitea:mainfromsilverwind:btnalign
Jul 18, 2025

Conversation

@silverwind
Copy link
Member

@silverwindsilverwind commentedJul 9, 2025•
edited
Loading

This change concerns the "Edit" and "New Issue" button on top right. With this change, switching from the issue list into an issue, the "New Issue" button will no longer "shift" from the postion on the previous page.

Screenshot 2025-07-09 at 17 37 31Screenshot 2025-07-09 at 17 37 19

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 9, 2025
@silverwindsilverwind added the backport/v1.24This PR should be backported to Gitea 1.24 labelJul 9, 2025
@silverwind
Copy link
MemberAuthor

silverwind commentedJul 10, 2025•
edited
Loading

Found a slightly better fix. By removingalign-items: center from the parent, we achieve the same outcome of start-aligned flex children.

@silverwindsilverwind changed the titleAlignissue-title-buttonsAlignissue-title-buttons withlist-headerJul 10, 2025
@wxiaoguang
Copy link
Contributor

Then it mis-aligns

image

@silverwind
Copy link
MemberAuthor

silverwind commentedJul 11, 2025•
edited
Loading

I guess we can attempt to center single-line title with the buttons. Button position is fine, so the text has to move.

@wxiaoguang
Copy link
Contributor

-> Refactor view issue & comment list styles#35061

@silverwind
Copy link
MemberAuthor

silverwind commentedJul 14, 2025•
edited
Loading

#35061 does not do anything regarding the "New Issue" button moving down when navigating from issue list to issue.

@wxiaoguang
Copy link
Contributor

Really? After "merge with main branch", this PR doesn't provide any other changes.

imageimage

@wxiaoguang
Copy link
Contributor

wxiaoguang commentedJul 14, 2025•
edited
Loading

And I don't think it is a must to align components between pages.

For example: if there is "pinned issues", then the "New Issue" button also jumps.

If you'd like to align "everything", you need to align the issue list page's top search bar (including the search input and "New Issue" button) and the issue title line, to make them have the same "visual" height and "visually" center aligned.

@silverwind
Copy link
MemberAuthor

Pushed a different tweak, now text is centered and button does not shift on page switch. And yes I'm only optimizing the common case with no pins and no recently-pushed notice.

image

@silverwind
Copy link
MemberAuthor

Also fixed the title edit toggle, nothing shifts and I was able to remove another unnecessary css rule.

@silverwindsilverwind removed the backport/v1.24This PR should be backported to Gitea 1.24 labelJul 14, 2025
@silverwind
Copy link
MemberAuthor

#35061 was not backported, so this likely can't either.

Signed-off-by: silverwind <me@silverwind.io>
Signed-off-by: silverwind <me@silverwind.io>
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 14, 2025
@wxiaoguangwxiaoguang added this to the1.25.0 milestoneJul 14, 2025
@GiteaBotGiteaBot removed the lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelJul 18, 2025
@GiteaBotGiteaBot added the lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. labelJul 18, 2025
@silverwindsilverwindenabled auto-merge (squash)July 18, 2025 09:11
@silverwindsilverwind added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 18, 2025
@silverwindsilverwind merged commit13b9659 intogo-gitea:mainJul 18, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 18, 2025
@wxiaoguangwxiaoguang deleted the btnalign branchJuly 18, 2025 09:19
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 22, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Fix session gob (go-gitea#35128)  Replace `setup-python` with `setup-uv` (go-gitea#35116)  Don't use full-file highlight when there is a git diff textconv (go-gitea#35114)  Fix submodule parsing when the gitmodules is missing (go-gitea#35109)  Align `issue-title-buttons` with `list-header` (go-gitea#35018)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@wxiaoguangwxiaoguangwxiaoguang approved these changes

@delvhdelvhdelvh approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/frontend

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind@wxiaoguang@delvh@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp