NotificationsYou must be signed in to change notification settings
Fork6.3k
Star52.6k

Fix the response format for`actions/workflows`.#35009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

wxiaoguang merged 1 commit intogo-gitea:mainfromScionOfDesign:fix-list-repo-response

Jul 9, 2025

Merged

Fix the response format for`actions/workflows`.#35009

wxiaoguang merged 1 commit intogo-gitea:mainfromScionOfDesign:fix-list-repo-response

Jul 9, 2025

Conversation

Copy link

Contributor

ScionOfDesign commentedJul 9, 2025

This PR fixes the response format for the OpenAPI Spec ofActionsListRepositoryWorkflows.
It was specified in the OpenAPI spec as returning a[]*ActionWorkflow, but it actually should return aapi.ActionWorkflowResponse.

The test already expects anapi.ActionWorkflowResponse like expected.

Fix the response format foractions/workflows.

e27f9b1

GiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. label

Jul 9, 2025

github-actionsbot added modifies/api

This PR adds API routes or modifies them

modifies/goPull requests that update Go code labels

Jul 9, 2025

wxiaoguang approved these changes

Jul 9, 2025

View reviewed changes

Copy link

Contributor

wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also cc@bencurio and@ChristopherHX

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labels

Jul 9, 2025

ChristopherHX approved these changes

Jul 9, 2025

View reviewed changes

Copy link

Contributor

ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, I missed this in the original PR

I think adding a Backport label for 1.24 makes sense to fix the openapi there as well

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labels

Jul 9, 2025

ChristopherHX added the backport/v1.24This PR should be backported to Gitea 1.24 label

Jul 9, 2025

wxiaoguang merged commitbb0c84e intogo-gitea:main

Jul 9, 2025

26 checks passed

GiteaBot added this to the1.25.0 milestone

Jul 9, 2025

Copy link

Collaborator

GiteaBot commentedJul 9, 2025

I was unable to create a backport for 1.24.@ScionOfDesign, please send one manually. 🍵

go run ./contrib/backport 35009...  // fix git conflicts if anygo run ./contrib/backport --continue

GiteaBot added the backport/manualNo power to the bots! Create your backport yourself! label

Jul 9, 2025

Copy link

Contributor

wxiaoguang commentedJul 9, 2025

Hmm, swagger conflict makes it impossible to backport automatically.

If you'd like to try to backport, you can checkout 1.24 branch and apply the change to it again (manually 🤣 ) and submit a new PR targeting 1.24 branch.

If there is any difficulty, other maintainers and I could also help.

ChristopherHX pushed a commit to ChristopherHX/gitea that referenced this pull request

Jul 9, 2025

Fix the response format foractions/workflows. (go-gitea#35009)

a4778cc

Backportgo-gitea#35009This PR fixes the response format for the OpenAPI Spec of`ActionsListRepositoryWorkflows`.It was specified in the OpenAPI spec as returning a `[]*ActionWorkflow`,but it actually should return a `api.ActionWorkflowResponse`.The test already expects an `api.ActionWorkflowResponse` like expected.

Copy link

Contributor

ChristopherHX commentedJul 9, 2025•
edited
Loading

We could improve the backport program here, e.g. if the only conflict is swagger delte the generated file, regenerate.

I am doing this now manually

ChristopherHX mentioned this pull request

Jul 9, 2025

Fix the response format foractions/workflows. (#35009)#35016

Merged

silverwind pushed a commit that referenced this pull request

Jul 9, 2025

Fix the response format foractions/workflows. (#35009) (#35016)

053f918

Backport#35009This PR fixes the response format for the OpenAPI Spec of`ActionsListRepositoryWorkflows`.It was specified in the OpenAPI spec as returning a `[]*ActionWorkflow`,but it actually should return a `api.ActionWorkflowResponse`.The test already expects an `api.ActionWorkflowResponse` like expected.Co-authored-by: Scion <Filiecs2@gmail.com>

ScionOfDesign deleted the fix-list-repo-response branch

July 9, 2025 16:47

zjjhot added a commit to zjjhot/gitea that referenced this pull request

Jul 10, 2025

Merge remote-tracking branch 'giteaofficial/main'

c38270e

* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Docs/fix typo and grammar in CONTRIBUTING.md (go-gitea#35024)  fix: improve english grammar and readability in locale_en-US.ini (go-gitea#35017)  Add labeler config for `topic/code-linting` (go-gitea#35020)  Fix various problems (go-gitea#35012)  Fix the response format for `actions/workflows`. (go-gitea#35009)