Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.9k
Display badge on blocked & blocking issues#35004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Naxdy wants to merge1 commit intogo-gitea:mainChoose a base branch fromNaxdy:work/mark-blocked-issues
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5c109c0
todbaba71
CompareYou could use |
Ahh sorry, |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. modifies/frontendmodifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files modifies/translation
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR supersedes#29117 by offering a more simplistic approach to the problem. Any issue / PR that is blocked by another issue / PR, or is blocking one or more issues / PRs now has a badge displayed next to it indicating as such, right before the labels.
Both cases are represented by different icons, so it is easy to see at a glance which issues / PRs require attention more urgently than others (look for the ones that areblocking the most).
Only open issues / PRs are considered for determining blocking items, and closed issues / PRs cannot "block" anything anymore, but can still be "blocked by" something, in case an issue was closed due to being cancelled as opposed to implemented.
In the future, we might even think about adding a tooltip that lists the individual issues that are blocking / blocked.
Closes#29018
Screenshots
Issue List (Repo)
PR List (Repo)
Issue List (Global)
Unresolved questions
Is🤔style="background: none;"
fine? It feels hacky, and like there should be a better way without adding a whole new class