Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor OpenIDConnect to support SSH/FullName sync#34978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wxiaoguang merged 9 commits intogo-gitea:mainfromwxiaoguang:fix-oauth2
Jul 10, 2025

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguangwxiaoguang commentedJul 7, 2025•
edited
Loading

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 7, 2025
@github-actionsgithub-actionsbot added modifies/translation modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files modifies/frontend labelsJul 7, 2025
@wxiaoguangwxiaoguang added the type/featureCompletely new functionality. Can only be merged if feature freeze is not active. labelJul 7, 2025
@wxiaoguang
Copy link
ContributorAuthor

wxiaoguang commentedJul 7, 2025•
edited
Loading

Screenshot:

Details

image

@github-actionsgithub-actionsbot added the modifies/cliPR changes something on the CLI, i.e. gitea doctor or gitea admin labelJul 7, 2025
@lunny

This comment was marked as off-topic.

@wxiaoguang
Copy link
ContributorAuthor

wxiaoguang commentedJul 8, 2025•
edited
Loading

It seems there’s a bug: when attempting to log in via GitHub, it is incorrectly authenticated as a different user. Both the username and email are different from Github's username and email.

Have you checked your domain (visited domain vs callback domain)? Are they using the same session?

Update: it's said that that bug was caused by incorrect "user.login_source", related to:

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 8, 2025
@wxiaoguangwxiaoguang requested a review froma teamJuly 8, 2025 09:12
@wxiaoguang
Copy link
ContributorAuthor

@go-gitea/maintainers ready for review, thank you.

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 10, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 10, 2025
@wxiaoguangwxiaoguangenabled auto-merge (squash)July 10, 2025 16:45
@wxiaoguangwxiaoguangenabled auto-merge (squash)July 10, 2025 18:09
@wxiaoguangwxiaoguang merged commita5a3d9b intogo-gitea:mainJul 10, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.25.0 milestoneJul 10, 2025
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 10, 2025
@wxiaoguangwxiaoguang deleted the fix-oauth2 branchJuly 10, 2025 18:36
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 11, 2025
* giteaofficial/main:  Fix updating user visibility (go-gitea#35036)  Fix git commit committer parsing and add some tests (go-gitea#35007)  Refactor OpenIDConnect to support SSH/FullName sync (go-gitea#34978)  Support base64-encoded agit push options (go-gitea#35037)  Also display "recently pushed branch" alert on PR view (go-gitea#35001)  Make submodule link work with relative path (go-gitea#35034)  Update to go 1.24.5 (go-gitea#35031)  Improve CLI commands (go-gitea#34973)  Tweak eslint config, fix new issues (go-gitea#35019)# Conflicts:#templates/repo/commits_list.tmpl
@wxiaoguang
Copy link
ContributorAuthor

Need a following up fix: Fix session gob#35128

@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

+1 more reviewer

@hiifonghiifonghiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/cliPR changes something on the CLI, i.e. gitea doctor or gitea adminmodifies/frontendmodifies/goPull requests that update Go codemodifies/templatesThis PR modifies the template filesmodifies/translationtype/featureCompletely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

Pull user's 'Full Name' attribute from OAuth source automatically set SSH principal for users Import SSH keys via OIDC

4 participants

@wxiaoguang@lunny@hiifong@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp