Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve CLI commands#34973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wxiaoguang merged 17 commits intogo-gitea:mainfromTheFox0x7:cli-improvements
Jul 10, 2025
Merged

Conversation

@TheFox0x7
Copy link
Contributor

add makefile rule for shell completions, disable internal commands from showing in help
rework custom help so it only triggers on first level commands


help changes are mainly to work around regression:#34510 (comment)

since flags aren't marked as local they cascade through the app sobefore can be used as setup as we need to define flags once.
only main and it's subcommands are directly handled by it
instead of looping though the flags in linage, use their non localproperty
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 6, 2025
@github-actionsgithub-actionsbot added modifies/goPull requests that update Go code modifies/cliPR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/internal labelsJul 6, 2025
@silverwindsilverwind changed the titleadd genereted completions for shellsadd generated completions for shellsJul 7, 2025
@lunnylunny added this to the1.25.0 milestoneJul 9, 2025
work-path first, then config, then custom path
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 9, 2025
@wxiaoguangwxiaoguang changed the titleadd generated completions for shellsImprove CLI commandsJul 10, 2025
@wxiaoguang
Copy link
Contributor

Made more improvements to the "help" command/flag and added some tests. Does it look good to you?

@wxiaoguangwxiaoguang added the type/enhancementAn improvement of existing functionality labelJul 10, 2025
@TheFox0x7
Copy link
ContributorAuthor

It does. With that test rework we could addValidation func to this to check early if the file exists or is what it should be. Not sure if this something we want to add or not though.

I've also been thinking about adding a dedicatedconfig subcommand which would all end user to dump either the currently loaded config or one that would get loaded on init, which potentially would allow later addition ofconfig migrate between releases and would negate the need forDefault Config section. But that's for a different time, with it's own proposal and as companion to settings rework so just throwing it out there.

@wxiaoguang
Copy link
Contributor

IMO the "DEFAULT CONFIGURATION:" section is just a legacy design that we don't want to break (at the moment it is the only approach to see where the config file is, for example: in docker, there is a shell wrapper)

As long as there is no breaking, we can still keep "DEFAULT CONFIGURATION:" section for some time, until we would have some better designs.

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 10, 2025
@wxiaoguangwxiaoguang merged commit4b174e4 intogo-gitea:mainJul 10, 2025
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 11, 2025
* giteaofficial/main:  Fix updating user visibility (go-gitea#35036)  Fix git commit committer parsing and add some tests (go-gitea#35007)  Refactor OpenIDConnect to support SSH/FullName sync (go-gitea#34978)  Support base64-encoded agit push options (go-gitea#35037)  Also display "recently pushed branch" alert on PR view (go-gitea#35001)  Make submodule link work with relative path (go-gitea#35034)  Update to go 1.24.5 (go-gitea#35031)  Improve CLI commands (go-gitea#34973)  Tweak eslint config, fix new issues (go-gitea#35019)# Conflicts:#templates/repo/commits_list.tmpl
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangwxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/cliPR changes something on the CLI, i.e. gitea doctor or gitea adminmodifies/goPull requests that update Go codemodifies/internaltype/enhancementAn improvement of existing functionality

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TheFox0x7@wxiaoguang@lunny@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp