Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed minor typos in two files #HSFDPMUW#34944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 6 commits intogo-gitea:mainfromMrMars98:main
Jul 6, 2025
Merged

Conversation

@MrMars98
Copy link
Contributor

Fixed minor typos in CODE_OF_CONDUCT.md and README.md

I use the hashtag for a project at my university

Signed-off-by: MrMars98 <Marcel.Lang98@googlemail.com>
I use the hashtag for a project at my universitySigned-off-by: MrMars98 <Marcel.Lang98@googlemail.com>
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 3, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 3, 2025
@techknowlogick
Copy link
Member

Thanks for the PR, are you able to provide more context of the hashtag/your university course?

@TheFox0x7
Copy link
Contributor

I've looked into this out of curiosity. I have not found which university runs this course but it has been running since 2022.
They use the tag to id the contributions for the class. It's mainly been typo fixing.

Btw consider letting whoever runs the course know that the arbitrary tag with 0 context is a very weird choice. Especially for a title which is sometimes automated into release notes. PR body would be a better place IMO for it but I know it's most likely not up to you.

@bytedream
Copy link
Contributor

bytedream commentedJul 3, 2025
edited
Loading

I can confirm. I'm at the same university and funnily enough also visited that course (my PRs). For every PR with that hashtag (max. 5) you'll get points which you need to reach the best possible grade.

They use the tag to id the contributions for the class. It's mainly been typo fixing.

The only requirement is to have a merged PR with the hashtag in the title. The lecture is mostly visited by first semester students (some of whom have just learned programming), so typofixing is the best and fasted thing they can do imo.

Btw consider letting whoever runs the course know that the arbitrary tag with 0 context is a very weird choice. Especially for a title which is sometimes automated into release notes. PR body would be a better place IMO for it but I know it's most likely not up to you.

Already did, I also think it's a bad choice but the lecturer didn't want to change it (but you can still say it@MrMars98, maybe he'll change his mind if more students mention it). He uses some script to crawl all PRs the students send to him to check if the title contains the hashtag (at least it was like that when I visited it).

TheFox0x7 and maximizzar reacted with thumbs up emoji

@MrMars98
Copy link
ContributorAuthor

Already did, I also think it's a bad choice but the lecturer didn't want to change it (but you can still say it@MrMars98, maybe he'll change his mind if more students mention it). He uses some script to crawl all PRs the students send to him to check if the title contains the hashtag (at least it was like that when I visited it).

Yeah, the whole course pretty much told him that it's stupid and he said he will consider changing it for the next time he does it (he probably won't). The hashtag is unfortunately required in the title.

bytedream, TheFox0x7, maximizzar, delvh, and lafriks reacted with laugh emoji

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 4, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 6, 2025
@lunnylunny merged commitba943fb intogo-gitea:mainJul 6, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.25.0 milestoneJul 6, 2025
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 6, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 7, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Rerun job only when run is done (go-gitea#34970)  Enable gocritic `equalFold` and fix issues (go-gitea#34952)  Fixed minor typos in two files #HSFDPMUW (go-gitea#34944)  Improve project & label color picker and image scroll (go-gitea#34971)  Refactor webhook and fix feishu/lark secret (go-gitea#34961)  Improve OAuth2 provider (correct Issuer, respect ENABLED) (go-gitea#34966)  Merge index.js (go-gitea#34963)  [skip ci] Updated translations via Crowdin  Mark old reviews as stale on agit pr updates (go-gitea#34933)  Refactor "delete-button" to "link-action" (go-gitea#34962)  Refactor frontend unique id & comment (go-gitea#34958)  Refactor some trivial problems (go-gitea#34959)  Upgrade security public key (go-gitea#34956)  Fix git graph page (go-gitea#34948)  Update JS dependencies (go-gitea#34951)  Refactor head navbar icons (go-gitea#34922)# Conflicts:#templates/base/head_navbar.tmpl
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@silverwindsilverwindsilverwind approved these changes

@lafrikslafrikslafriks approved these changes

@delvhdelvhdelvh approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/docs

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

9 participants

@MrMars98@techknowlogick@TheFox0x7@bytedream@silverwind@lafriks@delvh@lunny@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp