Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix http auth header parsing#34936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wxiaoguang merged 3 commits intogo-gitea:mainfromwxiaoguang:fix-string-equal
Jul 3, 2025

Conversation

@wxiaoguang
Copy link
Contributor

Usingstrings.EqualFold is wrong in many cases.

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 2, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelJul 2, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 3, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 3, 2025
fallthrough
case"token":
returnhandleLFSToken(ctx,tokenSHA,target,mode)
token,ok:=httpauth.ParseAuthorizationHeaderBearerToken(authorization)
Copy link
Member

@hiifonghiifongJul 3, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ref：The Git LFS API uses HTTP Basic Authentication to authorize requests.

I'm not sure, would there be any other issues with us using token?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That "basic" is not this "basic"

@wxiaoguangwxiaoguangenabled auto-merge (squash)July 3, 2025 02:36
@wxiaoguangwxiaoguang merged commitd6d643f intogo-gitea:mainJul 3, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.25.0 milestoneJul 3, 2025
@wxiaoguangwxiaoguang deleted the fix-string-equal branchJuly 3, 2025 03:02
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 4, 2025
* giteaofficial/main:  Fix http auth header parsing (go-gitea#34936)  Don't send trigger for a pending review's comment create/update/delete (go-gitea#34928)  Support getting last commit message using contents-ext API (go-gitea#34904)  [skip ci] Updated translations via Crowdin  Exclude devtest.ts from tailwindcss (go-gitea#34935)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

+1 more reviewer

@hiifonghiifonghiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go code

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang@lunny@hiifong@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp