Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't send trigger for a pending review's comment create/update/delete#34928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@lunny
Copy link
Member

@lunnylunny commentedJul 2, 2025
edited
Loading

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 2, 2025
@lunnylunny added type/bug backport/v1.24This PR should be backported to Gitea 1.24 and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 2, 2025
@github-actionsgithub-actionsbot added lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. modifies/goPull requests that update Go code and removed type/bug backport/v1.24This PR should be backported to Gitea 1.24 labelsJul 2, 2025
@lunnylunny added type/bug backport/v1.24This PR should be backported to Gitea 1.24 labelsJul 2, 2025
@wxiaoguang
Copy link
Contributor

func shouldSendIssueChangeNotification(...) bool {}

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 2, 2025
@lunny
Copy link
MemberAuthor

func shouldSendIssueChangeNotification(...) bool {}

681ffa6

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 3, 2025
@wxiaoguangwxiaoguang merged commit8cbec63 intogo-gitea:mainJul 3, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.25.0 milestoneJul 3, 2025
@wxiaoguangwxiaoguang deleted the lunny/pending_comment_not_trigger_webhook branchJuly 3, 2025 02:35
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull requestJul 3, 2025
@GiteaBotGiteaBot added the backport/doneAll backports for this PR have been created labelJul 3, 2025
wxiaoguang added a commit that referenced this pull requestJul 3, 2025
#34928) (#34939)Backport#34928 by lunnyFix#18846Fix#34924Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 4, 2025
* giteaofficial/main:  Fix http auth header parsing (go-gitea#34936)  Don't send trigger for a pending review's comment create/update/delete (go-gitea#34928)  Support getting last commit message using contents-ext API (go-gitea#34904)  [skip ci] Updated translations via Crowdin  Exclude devtest.ts from tailwindcss (go-gitea#34935)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@wxiaoguangwxiaoguangwxiaoguang approved these changes

@delvhdelvhdelvh approved these changes

+1 more reviewer

@hiifonghiifonghiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/doneAll backports for this PR have been createdbackport/v1.24This PR should be backported to Gitea 1.24lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go codetype/bug

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

Deleting comment in review triggers dicord webhook Do not track edits and deletions of pending review comments

5 participants

@lunny@wxiaoguang@delvh@hiifong@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp