Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor head navbar icons#34922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
silverwind merged 5 commits intogo-gitea:mainfromwxiaoguang:fix-navbar-icon
Jul 4, 2025

Conversation

@wxiaoguang
Copy link
Contributor

No description provided.

silverwind reacted with thumbs up emoji
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJul 1, 2025
@wxiaoguang
Copy link
ContributorAuthor

image

@github-actionsgithub-actionsbot added modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files modifies/frontend labelsJul 1, 2025
@wxiaoguangwxiaoguang changed the titleRefactor headnav bar iconsRefactor head navbar iconsJul 1, 2025
@silverwind
Copy link
Member

silverwind commentedJul 1, 2025
edited
Loading

Would swap position with the "+" icon.

@wxiaoguang
Copy link
ContributorAuthor

Would swap position with the "+" icon.

That's very difficult by current layout. Feel free to propose changes and edit this PR directly.

@silverwind
Copy link
Member

I see, we have this complexity with the mobile layout.

@silverwind
Copy link
Member

silverwind commentedJul 1, 2025
edited
Loading

We should probably remove this button in the user menu now, given that it's duplicate?

image

@silverwind
Copy link
Member

Found a bug, opening/notifications gives this 500:

Render failed, failed to render template: user/notification/notification, error: template error: builtin(static):user/notification/notification_div:3:32 : executing "user/notification/notification_div" at <call .NotificationUnreadCount ctx>: error calling call: call of nil----------------------------------------------------------------------{{$notificationUnreadCount := call .NotificationUnreadCount ctx}}

@wxiaoguang
Copy link
ContributorAuthor

We should probably remove this button in the user menu now, given that it's duplicate?

Removed in127274d

Found a bug, opening/notifications gives this 500:

Hmm, the page was covered by tests inlinks_test.go, but the tests were wrong and didn't really test. Fixed together in127274d

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJul 2, 2025
@silverwind
Copy link
Member

silverwind commentedJul 2, 2025
edited
Loading

One minor related thing: The admin page currently says this on top left:

image

But we call this page "Site Administration" on this button, so I'd prefer if we change this title to the same translation string.

@wxiaoguang
Copy link
ContributorAuthor

so I'd prefer if we change this title to the same translation string.

I am not sure which one is better. Feel free to pick one to replace the other.

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 2, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 3, 2025
@lunnylunny added this to the1.25.0 milestoneJul 3, 2025
@silverwind
Copy link
Member

so I'd prefer if we change this title to the same translation string.

I am not sure which one is better. Feel free to pick one to replace the other.

Can do that later.

@silverwindsilverwind merged commit71e151c intogo-gitea:mainJul 4, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJul 4, 2025
@wxiaoguangwxiaoguang deleted the fix-navbar-icon branchJuly 4, 2025 12:14
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 7, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Rerun job only when run is done (go-gitea#34970)  Enable gocritic `equalFold` and fix issues (go-gitea#34952)  Fixed minor typos in two files #HSFDPMUW (go-gitea#34944)  Improve project & label color picker and image scroll (go-gitea#34971)  Refactor webhook and fix feishu/lark secret (go-gitea#34961)  Improve OAuth2 provider (correct Issuer, respect ENABLED) (go-gitea#34966)  Merge index.js (go-gitea#34963)  [skip ci] Updated translations via Crowdin  Mark old reviews as stale on agit pr updates (go-gitea#34933)  Refactor "delete-button" to "link-action" (go-gitea#34962)  Refactor frontend unique id & comment (go-gitea#34958)  Refactor some trivial problems (go-gitea#34959)  Upgrade security public key (go-gitea#34956)  Fix git graph page (go-gitea#34948)  Update JS dependencies (go-gitea#34951)  Refactor head navbar icons (go-gitea#34922)# Conflicts:#templates/base/head_navbar.tmpl
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsOct 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@silverwindsilverwindsilverwind approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/frontendmodifies/goPull requests that update Go codemodifies/templatesThis PR modifies the template files

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang@silverwind@lunny@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp