Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Fix: RPM package download routing & missing package version count#34909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
wxiaoguang merged 7 commits intogo-gitea:mainfromExplodingDragon:bugfix-rpm-and-pkg-versionsJun 30, 2025
Merged
Fix: RPM package download routing & missing package version count#34909
wxiaoguang merged 7 commits intogo-gitea:mainfromExplodingDragon:bugfix-rpm-and-pkg-versionsJun 30, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>Signed-off-by: Exploding Dragon <explodingfkl@gmail.com>
Contributor
wxiaoguang commentedJun 30, 2025
I think we can clarify the download behavior by1377b65 , does it look good to you? |
wxiaoguang approved these changesJun 30, 2025
Contributor
wxiaoguang commentedJun 30, 2025
Hmm, the regression is related to Refactor packages (#34777). Old code used regexp Thank you very much for figuring it out and add the test. |
hiifong approved these changesJun 30, 2025
09bb19a intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 1, 2025
* giteaofficial/main: Fix modal + form abuse (go-gitea#34921) [skip ci] Updated translations via Crowdin Follow file symlinks in the UI to their target (go-gitea#28835) Fix issue filter (go-gitea#34914) Fix: RPM package download routing & missing package version count (go-gitea#34909) Add support for 3D/CAD file formats preview (go-gitea#34794)
bdruth added a commit to bdruth/gitea that referenced this pull requestJul 4, 2025
…h/gitea into feature/enhanced-workflow-runs-api* 'feature/enhanced-workflow-runs-api' of github.com:bdruth/gitea: [skip ci] Updated translations via Crowdin Follow file symlinks in the UI to their target (go-gitea#28835) Fix issue filter (go-gitea#34914) Fix: RPM package download routing & missing package version count (go-gitea#34909) Add support for 3D/CAD file formats preview (go-gitea#34794) Add a `login`/`login-name`/`username` disambiguation to affected endpoint parameters and response/request models (go-gitea#34901) Improve tags list page (go-gitea#34898) [skip ci] Updated translations via Crowdin docs: fix typo in pull request merge warning message text (go-gitea#34899) Refactor container package (go-gitea#34877) [skip ci] Updated translations via Crowdin
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix RPM package download routing (This is actually a regression bug from#27056)
gitea/services/packages/rpm/repository.go
Line 439 in176962c
Fix missing package version count